Skip to content

fix: prevent selecting already selected permissions #3669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chronark merged 2 commits into from
Jul 28, 2025
Merged

fix: prevent selecting already selected permissions #3669

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2427a5f
fix: prevent selecting already selected permissions
ogzhanolguncu Jul 28, 2025
0ecffb4
Merge branch 'main' into fix-rootkeys-select-all
chronark Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions apps/dashboard/app/(app)/settings/root-keys/new/client.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,9 @@ export const Client: React.FC<Props> = ({ apis }) => {
},
});

const snippet = `curl -XPOST '${process.env.NEXT_PUBLIC_UNKEY_API_URL ?? "https://api.unkey.dev"}/v1/keys.createKey' \\
const snippet = `curl -XPOST '${
process.env.NEXT_PUBLIC_UNKEY_API_URL ?? "https://api.unkey.dev"
}/v1/keys.createKey' \\
-H 'Authorization: Bearer ${key.data?.key}' \\
-H 'Content-Type: application/json' \\
-d '{
Expand All @@ -122,10 +124,15 @@ export const Client: React.FC<Props> = ({ apis }) => {

const handleSetChecked = (permission: UnkeyPermission, checked: boolean) => {
setSelectedPermissions((prevPermissions) => {
const permissionSet = new Set(prevPermissions);

if (checked) {
return [...prevPermissions, permission];
permissionSet.add(permission);
} else {
permissionSet.delete(permission);
}
return prevPermissions.filter((r) => r !== permission);

return Array.from(permissionSet);
});
};

Expand Down