fix: scope cache keys to a workspace to prevent leaking of data by chronark · Pull Request #3633 · unkeyed/unkey

chronark · 2025-07-18T18:09:34Z

What does this PR do?

Refactors the ratelimit namespace cache to use a more robust scoped key approach. This change replaces the previous RatelimitNamespaceByNameCache with a new RatelimitNamespaceCache that uses a ScopedKey type to properly isolate cached data between workspaces.

The new implementation:

Introduces a ScopedKey type that combines workspace ID with resource keys
Updates all ratelimit handlers to use the new cache interface
Improves cache invalidation by supporting removal of multiple keys at once
Ensures proper workspace isolation for cached ratelimit namespace data

Fixes # (issue)

Type of change

Chore (refactoring code, technical debt, workflow improvements)
Enhancement (small improvements)

How should this be tested?

Test all ratelimit API endpoints to ensure they work correctly with the new cache implementation
Verify that cache isolation works properly between workspaces
Check that cache invalidation works when setting or deleting overrides

Checklist

Required

Summary by CodeRabbit

New Features
- Added a new cache key type to improve workspace-level isolation for cached resources.
Refactor
- Updated cache keying for rate limit namespace operations to use workspace-scoped keys instead of simple strings.
- Improved cache invalidation logic to support removal of multiple entries at once.
- Renamed and updated cache-related fields and methods to reflect new keying strategy.
Tests
- Updated test setups to use the new cache field names and keying approach.

vercel · 2025-07-18T18:09:38Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
dashboard	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 18, 2025 6:11pm
engineering	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 18, 2025 6:11pm

coderabbitai · 2025-07-18T18:09:41Z

📝 Walkthrough

Walkthrough

The changes update the ratelimit namespace cache system to use a new ScopedKey struct, enabling cache entries to be scoped by workspace and resource identifier (name or ID). Cache field names and types are updated throughout handlers, tests, and the cache infrastructure. The cache removal API now supports removing multiple keys at once.

Changes

Files / Areas	Change Summary
`go/apps/api/routes/register.go`, `.../handler.go`, test files for ratelimit routes	Renamed cache field from `RatelimitNamespaceByNameCache` (keyed by string) to `RatelimitNamespaceCache` (keyed by `ScopedKey`).
`go/internal/services/caches/caches.go`	Renamed and retyped cache field in `Caches` struct; updated initialization to use `ScopedKey`.
`go/pkg/cache/interface.go`, `go/pkg/cache/cache.go`, `go/pkg/cache/noop.go`, `.../tracing.go`	Changed `Remove` method to accept variadic keys for bulk removal; updated interface and all implementations.
`go/pkg/cache/scoped_key.go`	Added new `ScopedKey` struct for workspace-scoped cache keys, with documentation and usage rationale.

Sequence Diagram(s)

sequenceDiagram
    participant Handler
    participant Cache
    participant DB

    Handler->>Cache: Get(ScopedKey{WorkspaceID, Key})
    alt Cache miss
        Cache->>DB: Query FindRatelimitNamespace by WorkspaceID and Key
        DB-->>Cache: Return namespace data
        Cache-->>Handler: Return namespace data
    else Cache hit
        Cache-->>Handler: Return cached namespace data
    end

    Handler->>Cache: Remove(ctx, ScopedKey{WorkspaceID, NamespaceID}, ScopedKey{WorkspaceID, NamespaceName})

Suggested reviewers

perkinsjr
mcstepp
MichaelUnkey
ogzhanolguncu

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bd4f010 and 006329c.

📒 Files selected for processing (32)

go/apps/api/routes/register.go (1 hunks)
go/apps/api/routes/v2_ratelimit_delete_override/200_test.go (1 hunks)
go/apps/api/routes/v2_ratelimit_delete_override/400_test.go (1 hunks)
go/apps/api/routes/v2_ratelimit_delete_override/401_test.go (1 hunks)
go/apps/api/routes/v2_ratelimit_delete_override/403_test.go (1 hunks)
go/apps/api/routes/v2_ratelimit_delete_override/404_test.go (1 hunks)
go/apps/api/routes/v2_ratelimit_delete_override/handler.go (2 hunks)
go/apps/api/routes/v2_ratelimit_get_override/200_test.go (1 hunks)
go/apps/api/routes/v2_ratelimit_get_override/400_test.go (1 hunks)
go/apps/api/routes/v2_ratelimit_get_override/401_test.go (1 hunks)
go/apps/api/routes/v2_ratelimit_get_override/403_test.go (1 hunks)
go/apps/api/routes/v2_ratelimit_get_override/404_test.go (1 hunks)
go/apps/api/routes/v2_ratelimit_get_override/handler.go (1 hunks)
go/apps/api/routes/v2_ratelimit_limit/200_test.go (1 hunks)
go/apps/api/routes/v2_ratelimit_limit/400_test.go (1 hunks)
go/apps/api/routes/v2_ratelimit_limit/401_test.go (1 hunks)
go/apps/api/routes/v2_ratelimit_limit/403_test.go (1 hunks)
go/apps/api/routes/v2_ratelimit_limit/404_test.go (1 hunks)
go/apps/api/routes/v2_ratelimit_limit/accuracy_test.go (1 hunks)
go/apps/api/routes/v2_ratelimit_limit/handler.go (2 hunks)
go/apps/api/routes/v2_ratelimit_set_override/200_test.go (1 hunks)
go/apps/api/routes/v2_ratelimit_set_override/400_test.go (1 hunks)
go/apps/api/routes/v2_ratelimit_set_override/401_test.go (1 hunks)
go/apps/api/routes/v2_ratelimit_set_override/403_test.go (1 hunks)
go/apps/api/routes/v2_ratelimit_set_override/404_test.go (1 hunks)
go/apps/api/routes/v2_ratelimit_set_override/handler.go (2 hunks)
go/internal/services/caches/caches.go (3 hunks)
go/pkg/cache/cache.go (1 hunks)
go/pkg/cache/interface.go (1 hunks)
go/pkg/cache/middleware/tracing.go (1 hunks)
go/pkg/cache/noop.go (1 hunks)
go/pkg/cache/scoped_key.go (1 hunks)

🧰 Additional context used

🧠 Learnings (27)

📓 Common learnings

Learnt from: ogzhanolguncu
PR: unkeyed/unkey#2872
File: apps/dashboard/lib/trpc/routers/ratelimit/createNamespace.ts:36-39
Timestamp: 2025-04-08T09:34:24.576Z
Learning: When querying or updating namespaces in the Unkey dashboard, always scope the operations to the current workspace using `eq(table.workspaceId, ctx.workspace.id)` to prevent cross-workspace access.

Learnt from: ogzhanolguncu
PR: unkeyed/unkey#2872
File: apps/dashboard/lib/trpc/routers/ratelimit/createNamespace.ts:36-39
Timestamp: 2025-04-08T09:34:24.576Z
Learning: In the Unkey dashboard, when making database queries involving workspaces, use `ctx.workspace.id` directly instead of fetching the workspace separately for better performance and security.

go/apps/api/routes/v2_ratelimit_delete_override/400_test.go (1)

Learnt from: chronark
PR: unkeyed/unkey#2126
File: apps/api/src/routes/v1_ratelimit_getOverride.happy.test.ts:36-36
Timestamp: 2024-11-13T19:06:36.786Z
Learning: In the rate limit test files (e.g., `apps/api/src/routes/v1_ratelimit_getOverride.happy.test.ts`), URL parameters like `namespaceId` and `identifier` do not need to be URL-encoded in the test code because the values used are always considered safe within the test environment.

go/apps/api/routes/v2_ratelimit_limit/200_test.go (2)

Learnt from: chronark
PR: unkeyed/unkey#2126
File: apps/api/src/routes/v1_ratelimit_getOverride.happy.test.ts:36-36
Timestamp: 2024-11-13T19:06:36.786Z
Learning: In the rate limit test files (e.g., `apps/api/src/routes/v1_ratelimit_getOverride.happy.test.ts`), URL parameters like `namespaceId` and `identifier` do not need to be URL-encoded in the test code because the values used are always considered safe within the test environment.

Learnt from: chronark
PR: unkeyed/unkey#2544
File: apps/api/src/pkg/env.ts:4-6
Timestamp: 2024-10-23T12:05:31.121Z
Learning: The `cloudflareRatelimiter` type definition in `apps/api/src/pkg/env.ts` should not have its interface changed; it should keep the `limit` method returning `Promise<{ success: boolean }>` without additional error properties.

go/apps/api/routes/v2_ratelimit_limit/accuracy_test.go (2)

Learnt from: chronark
PR: unkeyed/unkey#2126
File: apps/api/src/routes/v1_ratelimit_getOverride.happy.test.ts:36-36
Timestamp: 2024-11-13T19:06:36.786Z
Learning: In the rate limit test files (e.g., `apps/api/src/routes/v1_ratelimit_getOverride.happy.test.ts`), URL parameters like `namespaceId` and `identifier` do not need to be URL-encoded in the test code because the values used are always considered safe within the test environment.

Learnt from: chronark
PR: unkeyed/unkey#2544
File: apps/api/src/pkg/env.ts:4-6
Timestamp: 2024-10-23T12:05:31.121Z
Learning: The `cloudflareRatelimiter` type definition in `apps/api/src/pkg/env.ts` should not have its interface changed; it should keep the `limit` method returning `Promise<{ success: boolean }>` without additional error properties.

go/apps/api/routes/v2_ratelimit_limit/404_test.go (1)

Learnt from: chronark
PR: unkeyed/unkey#2126
File: apps/api/src/routes/v1_ratelimit_getOverride.happy.test.ts:36-36
Timestamp: 2024-11-13T19:06:36.786Z
Learning: In the rate limit test files (e.g., `apps/api/src/routes/v1_ratelimit_getOverride.happy.test.ts`), URL parameters like `namespaceId` and `identifier` do not need to be URL-encoded in the test code because the values used are always considered safe within the test environment.

go/apps/api/routes/v2_ratelimit_get_override/200_test.go (1)

Learnt from: chronark
PR: unkeyed/unkey#2126
File: apps/api/src/routes/v1_ratelimit_getOverride.happy.test.ts:36-36
Timestamp: 2024-11-13T19:06:36.786Z
Learning: In the rate limit test files (e.g., `apps/api/src/routes/v1_ratelimit_getOverride.happy.test.ts`), URL parameters like `namespaceId` and `identifier` do not need to be URL-encoded in the test code because the values used are always considered safe within the test environment.

go/apps/api/routes/v2_ratelimit_limit/403_test.go (1)

Learnt from: chronark
PR: unkeyed/unkey#2126
File: apps/api/src/routes/v1_ratelimit_getOverride.happy.test.ts:36-36
Timestamp: 2024-11-13T19:06:36.786Z
Learning: In the rate limit test files (e.g., `apps/api/src/routes/v1_ratelimit_getOverride.happy.test.ts`), URL parameters like `namespaceId` and `identifier` do not need to be URL-encoded in the test code because the values used are always considered safe within the test environment.

go/apps/api/routes/v2_ratelimit_get_override/404_test.go (1)

Learnt from: chronark
PR: unkeyed/unkey#2126
File: apps/api/src/routes/v1_ratelimit_getOverride.happy.test.ts:36-36
Timestamp: 2024-11-13T19:06:36.786Z
Learning: In the rate limit test files (e.g., `apps/api/src/routes/v1_ratelimit_getOverride.happy.test.ts`), URL parameters like `namespaceId` and `identifier` do not need to be URL-encoded in the test code because the values used are always considered safe within the test environment.

go/apps/api/routes/v2_ratelimit_get_override/403_test.go (1)

Learnt from: chronark
PR: unkeyed/unkey#2126
File: apps/api/src/routes/v1_ratelimit_getOverride.happy.test.ts:36-36
Timestamp: 2024-11-13T19:06:36.786Z
Learning: In the rate limit test files (e.g., `apps/api/src/routes/v1_ratelimit_getOverride.happy.test.ts`), URL parameters like `namespaceId` and `identifier` do not need to be URL-encoded in the test code because the values used are always considered safe within the test environment.

go/apps/api/routes/v2_ratelimit_set_override/401_test.go (1)

Learnt from: chronark
PR: unkeyed/unkey#2126
File: apps/api/src/routes/v1_ratelimit_getOverride.happy.test.ts:36-36
Timestamp: 2024-11-13T19:06:36.786Z
Learning: In the rate limit test files (e.g., `apps/api/src/routes/v1_ratelimit_getOverride.happy.test.ts`), URL parameters like `namespaceId` and `identifier` do not need to be URL-encoded in the test code because the values used are always considered safe within the test environment.

go/apps/api/routes/v2_ratelimit_set_override/400_test.go (1)

Learnt from: chronark
PR: unkeyed/unkey#2126
File: apps/api/src/routes/v1_ratelimit_getOverride.happy.test.ts:36-36
Timestamp: 2024-11-13T19:06:36.786Z
Learning: In the rate limit test files (e.g., `apps/api/src/routes/v1_ratelimit_getOverride.happy.test.ts`), URL parameters like `namespaceId` and `identifier` do not need to be URL-encoded in the test code because the values used are always considered safe within the test environment.

go/apps/api/routes/v2_ratelimit_delete_override/403_test.go (1)

Learnt from: chronark
PR: unkeyed/unkey#2126
File: apps/api/src/routes/v1_ratelimit_getOverride.happy.test.ts:36-36
Timestamp: 2024-11-13T19:06:36.786Z
Learning: In the rate limit test files (e.g., `apps/api/src/routes/v1_ratelimit_getOverride.happy.test.ts`), URL parameters like `namespaceId` and `identifier` do not need to be URL-encoded in the test code because the values used are always considered safe within the test environment.

go/apps/api/routes/v2_ratelimit_delete_override/200_test.go (1)

Learnt from: chronark
PR: unkeyed/unkey#2126
File: apps/api/src/routes/v1_ratelimit_getOverride.happy.test.ts:36-36
Timestamp: 2024-11-13T19:06:36.786Z
Learning: In the rate limit test files (e.g., `apps/api/src/routes/v1_ratelimit_getOverride.happy.test.ts`), URL parameters like `namespaceId` and `identifier` do not need to be URL-encoded in the test code because the values used are always considered safe within the test environment.

go/apps/api/routes/v2_ratelimit_get_override/401_test.go (1)

Learnt from: chronark
PR: unkeyed/unkey#2126
File: apps/api/src/routes/v1_ratelimit_getOverride.happy.test.ts:36-36
Timestamp: 2024-11-13T19:06:36.786Z
Learning: In the rate limit test files (e.g., `apps/api/src/routes/v1_ratelimit_getOverride.happy.test.ts`), URL parameters like `namespaceId` and `identifier` do not need to be URL-encoded in the test code because the values used are always considered safe within the test environment.

go/apps/api/routes/v2_ratelimit_set_override/handler.go (1)

Learnt from: ogzhanolguncu
PR: unkeyed/unkey#2872
File: apps/dashboard/lib/trpc/routers/ratelimit/createNamespace.ts:36-39
Timestamp: 2025-04-08T09:34:24.576Z
Learning: When querying or updating namespaces in the Unkey dashboard, always scope the operations to the current workspace using `eq(table.workspaceId, ctx.workspace.id)` to prevent cross-workspace access.

go/apps/api/routes/v2_ratelimit_delete_override/404_test.go (1)

Learnt from: chronark
PR: unkeyed/unkey#2126
File: apps/api/src/routes/v1_ratelimit_getOverride.happy.test.ts:36-36
Timestamp: 2024-11-13T19:06:36.786Z
Learning: In the rate limit test files (e.g., `apps/api/src/routes/v1_ratelimit_getOverride.happy.test.ts`), URL parameters like `namespaceId` and `identifier` do not need to be URL-encoded in the test code because the values used are always considered safe within the test environment.

go/apps/api/routes/v2_ratelimit_set_override/403_test.go (2)

Learnt from: chronark
PR: unkeyed/unkey#2126
File: apps/api/src/routes/v1_ratelimit_getOverride.happy.test.ts:36-36
Timestamp: 2024-11-13T19:06:36.786Z
Learning: In the rate limit test files (e.g., `apps/api/src/routes/v1_ratelimit_getOverride.happy.test.ts`), URL parameters like `namespaceId` and `identifier` do not need to be URL-encoded in the test code because the values used are always considered safe within the test environment.

Learnt from: ogzhanolguncu
PR: unkeyed/unkey#2707
File: apps/dashboard/lib/trpc/routers/ratelimit/createOverride.ts:63-63
Timestamp: 2024-12-05T13:27:55.555Z
Learning: In `apps/dashboard/lib/trpc/routers/ratelimit/createOverride.ts`, when determining the maximum number of rate limit overrides (`max`), the intentional use of `const max = hasWorkspaceAccess("ratelimitOverrides", namespace.workspace) || 5;` allows `max` to fall back to `5` when `hasWorkspaceAccess` returns `0` or `false`. This fallback behavior is expected and intended in the codebase.

go/apps/api/routes/v2_ratelimit_set_override/404_test.go (1)

Learnt from: chronark
PR: unkeyed/unkey#2126
File: apps/api/src/routes/v1_ratelimit_getOverride.happy.test.ts:36-36
Timestamp: 2024-11-13T19:06:36.786Z
Learning: In the rate limit test files (e.g., `apps/api/src/routes/v1_ratelimit_getOverride.happy.test.ts`), URL parameters like `namespaceId` and `identifier` do not need to be URL-encoded in the test code because the values used are always considered safe within the test environment.

go/apps/api/routes/v2_ratelimit_get_override/handler.go (1)

Learnt from: chronark
PR: unkeyed/unkey#2544
File: apps/api/src/pkg/env.ts:4-6
Timestamp: 2024-10-23T12:05:31.121Z
Learning: The `cloudflareRatelimiter` type definition in `apps/api/src/pkg/env.ts` should not have its interface changed; it should keep the `limit` method returning `Promise<{ success: boolean }>` without additional error properties.

go/apps/api/routes/v2_ratelimit_limit/400_test.go (1)

Learnt from: chronark
PR: unkeyed/unkey#2126
File: apps/api/src/routes/v1_ratelimit_getOverride.happy.test.ts:36-36
Timestamp: 2024-11-13T19:06:36.786Z
Learning: In the rate limit test files (e.g., `apps/api/src/routes/v1_ratelimit_getOverride.happy.test.ts`), URL parameters like `namespaceId` and `identifier` do not need to be URL-encoded in the test code because the values used are always considered safe within the test environment.

go/apps/api/routes/v2_ratelimit_delete_override/401_test.go (1)

Learnt from: chronark
PR: unkeyed/unkey#2126
File: apps/api/src/routes/v1_ratelimit_getOverride.happy.test.ts:36-36
Timestamp: 2024-11-13T19:06:36.786Z
Learning: In the rate limit test files (e.g., `apps/api/src/routes/v1_ratelimit_getOverride.happy.test.ts`), URL parameters like `namespaceId` and `identifier` do not need to be URL-encoded in the test code because the values used are always considered safe within the test environment.

go/apps/api/routes/v2_ratelimit_limit/handler.go (2)

Learnt from: chronark
PR: unkeyed/unkey#2544
File: apps/api/src/pkg/env.ts:4-6
Timestamp: 2024-10-23T12:05:31.121Z
Learning: The `cloudflareRatelimiter` type definition in `apps/api/src/pkg/env.ts` should not have its interface changed; it should keep the `limit` method returning `Promise<{ success: boolean }>` without additional error properties.

Learnt from: ogzhanolguncu
PR: unkeyed/unkey#2872
File: apps/dashboard/lib/trpc/routers/ratelimit/createNamespace.ts:36-39
Timestamp: 2025-04-08T09:34:24.576Z
Learning: When querying or updating namespaces in the Unkey dashboard, always scope the operations to the current workspace using `eq(table.workspaceId, ctx.workspace.id)` to prevent cross-workspace access.

go/pkg/cache/scoped_key.go (2)

Learnt from: ogzhanolguncu
PR: unkeyed/unkey#2872
File: apps/dashboard/lib/trpc/routers/ratelimit/createNamespace.ts:36-39
Timestamp: 2025-04-08T09:34:24.576Z
Learning: In the Unkey dashboard, when making database queries involving workspaces, use `ctx.workspace.id` directly instead of fetching the workspace separately for better performance and security.

Learnt from: ogzhanolguncu
PR: unkeyed/unkey#2872
File: apps/dashboard/lib/trpc/routers/ratelimit/createNamespace.ts:36-39
Timestamp: 2025-04-08T09:34:24.576Z
Learning: When querying or updating namespaces in the Unkey dashboard, always scope the operations to the current workspace using `eq(table.workspaceId, ctx.workspace.id)` to prevent cross-workspace access.

go/apps/api/routes/v2_ratelimit_limit/401_test.go (1)

Learnt from: chronark
PR: unkeyed/unkey#2126
File: apps/api/src/routes/v1_ratelimit_getOverride.happy.test.ts:36-36
Timestamp: 2024-11-13T19:06:36.786Z
Learning: In the rate limit test files (e.g., `apps/api/src/routes/v1_ratelimit_getOverride.happy.test.ts`), URL parameters like `namespaceId` and `identifier` do not need to be URL-encoded in the test code because the values used are always considered safe within the test environment.

go/apps/api/routes/v2_ratelimit_set_override/200_test.go (1)

Learnt from: chronark
PR: unkeyed/unkey#2126
File: apps/api/src/routes/v1_ratelimit_getOverride.happy.test.ts:36-36
Timestamp: 2024-11-13T19:06:36.786Z
Learning: In the rate limit test files (e.g., `apps/api/src/routes/v1_ratelimit_getOverride.happy.test.ts`), URL parameters like `namespaceId` and `identifier` do not need to be URL-encoded in the test code because the values used are always considered safe within the test environment.

go/apps/api/routes/v2_ratelimit_get_override/400_test.go (1)

Learnt from: chronark
PR: unkeyed/unkey#2126
File: apps/api/src/routes/v1_ratelimit_getOverride.happy.test.ts:36-36
Timestamp: 2024-11-13T19:06:36.786Z
Learning: In the rate limit test files (e.g., `apps/api/src/routes/v1_ratelimit_getOverride.happy.test.ts`), URL parameters like `namespaceId` and `identifier` do not need to be URL-encoded in the test code because the values used are always considered safe within the test environment.

go/apps/api/routes/v2_ratelimit_delete_override/handler.go (1)

Learnt from: ogzhanolguncu
PR: unkeyed/unkey#2872
File: apps/dashboard/lib/trpc/routers/ratelimit/createNamespace.ts:36-39
Timestamp: 2025-04-08T09:34:24.576Z
Learning: When querying or updating namespaces in the Unkey dashboard, always scope the operations to the current workspace using `eq(table.workspaceId, ctx.workspace.id)` to prevent cross-workspace access.

🧬 Code Graph Analysis (22)

go/apps/api/routes/v2_ratelimit_delete_override/400_test.go (1)

go/apps/api/routes/v2_ratelimit_limit/404_test.go (1)

go/apps/api/routes/v2_ratelimit_get_override/200_test.go (1)

go/apps/api/routes/v2_ratelimit_limit/403_test.go (1)

go/apps/api/routes/v2_ratelimit_get_override/404_test.go (1)

go/apps/api/routes/v2_ratelimit_get_override/403_test.go (1)

go/apps/api/routes/v2_ratelimit_set_override/401_test.go (1)

go/apps/api/routes/v2_ratelimit_set_override/400_test.go (1)

go/apps/api/routes/v2_ratelimit_delete_override/403_test.go (1)

go/apps/api/routes/v2_ratelimit_delete_override/200_test.go (1)

go/apps/api/routes/v2_ratelimit_get_override/401_test.go (1)

go/apps/api/routes/v2_ratelimit_set_override/handler.go (2)

go/apps/api/routes/v2_ratelimit_delete_override/404_test.go (1)

go/apps/api/routes/v2_ratelimit_set_override/403_test.go (1)

go/apps/api/routes/v2_ratelimit_set_override/404_test.go (1)

go/apps/api/routes/v2_ratelimit_limit/400_test.go (1)

go/apps/api/routes/v2_ratelimit_delete_override/401_test.go (1)

go/pkg/cache/scoped_key.go (1)

go/apps/api/routes/v2_ratelimit_limit/401_test.go (1)

go/apps/api/routes/v2_ratelimit_set_override/200_test.go (1)

go/apps/api/routes/register.go (6)

go/apps/api/routes/v2_ratelimit_get_override/400_test.go (1)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)

GitHub Check: Build / Build
GitHub Check: Test Agent Local / test_agent_local
GitHub Check: Test Go API Local / Test
GitHub Check: Test API / API Test Local
GitHub Check: Test Packages / Test

🔇 Additional comments (37)

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

chronark · 2025-07-18T18:09:52Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2025-07-18T18:13:00Z

Thank you for following the naming conventions for pull request titles! 🙏

graphite-app · 2025-07-18T18:30:11Z

Graphite Automations

"Notify author when CI fails" took an action on this PR • (07/18/25)

1 teammate was notified to this PR based on Andreas Thomas's automation.

"Post a GIF when PR approved" took an action on this PR • (07/21/25)

1 gif was posted to this PR based on Andreas Thomas's automation.

Flo4604 · 2025-07-21T17:03:38Z

More of a nit, but what if we made the type a generic so we could later also scope keys to something else than a workspace

chronark · 2025-07-21T17:04:48Z

I thought about it, but figured there isn’t any point in preoptimizing this. any change would need a redeployment and therefore clean the cache anyways

Flo4604 · 2025-07-21T17:06:17Z

yeah fair

graphite-app · 2025-07-21T17:07:47Z

fix: scope cache keys to a workspace to prevent leaking of data

006329c

chronark mentioned this pull request Jul 18, 2025

feat: update openapi and accept a single namespace field everywhere #3634

Merged

18 tasks

chronark marked this pull request as ready for review July 18, 2025 18:11

chronark requested review from Flo4604, imeyer and perkinsjr as code owners July 18, 2025 18:11

vercel bot temporarily deployed to Preview – dashboard July 18, 2025 18:11 Inactive

vercel bot temporarily deployed to Preview – engineering July 18, 2025 18:11 Inactive

Flo4604 approved these changes Jul 21, 2025

View reviewed changes

Flo4604 enabled auto-merge July 21, 2025 17:07

Flo4604 added this pull request to the merge queue Jul 21, 2025

Merged via the queue into main with commit c9d76d6 Jul 21, 2025
31 of 32 checks passed

Flo4604 deleted the 07-18-fix_scope_cache_keys_to_a_workspace_to_prevent_leaking_of_data branch July 21, 2025 18:04

Conversation

chronark commented Jul 18, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Type of change

How should this be tested?

Checklist

Required

Summary by CodeRabbit

Uh oh!

vercel bot commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Suggested reviewers

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

chronark commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 18, 2025

Uh oh!

graphite-app bot commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Graphite Automations

Uh oh!

Flo4604 commented Jul 21, 2025

Uh oh!

chronark commented Jul 21, 2025

Uh oh!

Flo4604 commented Jul 21, 2025

Uh oh!

graphite-app bot commented Jul 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

chronark commented Jul 18, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented Jul 18, 2025 •

edited

Loading

coderabbitai bot commented Jul 18, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

chronark commented Jul 18, 2025 •

edited

Loading

graphite-app bot commented Jul 18, 2025 •

edited

Loading