-
Notifications
You must be signed in to change notification settings - Fork 610
refactor: add util for id shortening #3403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
850f555
refactor: add util for id shortening
ogzhanolguncu e48d73e
refactor: replace id shortenings with util
ogzhanolguncu f43775c
Merge branch 'main' into util-for-key-shortening
MichaelUnkey e1f067c
fix: typo
ogzhanolguncu 55ef758
Merge branch 'main' into util-for-key-shortening
ogzhanolguncu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| /** | ||
| * Shortens an ID by keeping a specified number of characters from the start and end, | ||
| * with customizable separator in between. | ||
| */ | ||
| export function shortenId( | ||
| id: string, | ||
| options: { | ||
| /** Number of characters to keep from the start (default: 8) */ | ||
| startChars?: number; | ||
| /** Number of characters to keep from the end (default: 4) */ | ||
| endChars?: number; | ||
| /** Separator between start and end (default: "...") */ | ||
| separator?: string; | ||
| /** Minimum length required to apply shortening (default: startChars + endChars + 3) */ | ||
| minLength?: number; | ||
| } = {}, | ||
| ): string { | ||
| const { | ||
| startChars = 8, | ||
| endChars = 4, | ||
| separator = "...", | ||
| minLength = startChars + endChars + 3, | ||
| } = options; | ||
|
|
||
| // Validate inputs | ||
| if (startChars < 0 || endChars < 0) { | ||
| throw new Error("startChars and endChars must be non-negative"); | ||
| } | ||
|
|
||
| if (startChars + endChars === 0) { | ||
| throw new Error("At least one of startChars or endChars must be greater than 0"); | ||
| } | ||
|
|
||
| // Return original if too short to meaningfully shorten | ||
| if (id.length <= minLength) { | ||
| return id; | ||
| } | ||
|
|
||
| // Handle edge case where requested chars exceed ID length | ||
| if (startChars + endChars >= id.length) { | ||
| return id; | ||
| } | ||
|
|
||
| const start = id.substring(0, startChars); | ||
| const end = id.substring(id.length - endChars); | ||
|
|
||
| return `${start}${separator}${end}`; | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.