chore: linter style fix

apps/api/src/routes/v1_identities_getIdentity.ts

@@ -80,7 +80,7 @@ export const registerV1IdentitiesGetIdentity = (app: App) =>
     const { identityId, externalId } = c.req.valid("query");
     const { db } = c.get("services");
 
-    if (!identityId && !externalId) {
+    if (!(identityId || externalId)) {
       throw new UnkeyApiError({
         code: "BAD_REQUEST",
         message: "Provide either identityId or externalId",

apps/api/src/routes/v1_identities_updateIdentity.ts

@@ -140,7 +140,7 @@ export const registerV1IdentitiesUpdateIdentity = (app: App) =>
 
     const { db, cache } = c.get("services");
 
-    if (!req.identityId && !req.externalId) {
+    if (!(req.identityId || req.externalId)) {
       throw new UnkeyApiError({
         code: "BAD_REQUEST",
         message: "Provide either identityId or externalId",
@@ -234,14 +234,14 @@ export const registerV1IdentitiesUpdateIdentity = (app: App) =>
         const updateRatelimits: Ratelimit[] = [];
         for (const rl of identity.ratelimits) {
           const newRl = req.ratelimits.find((r) => r.name === rl.name);
-          if (!newRl) {
-            deleteRatelimits.push(rl);
-          } else {
+          if (newRl) {
             updateRatelimits.push({
               ...rl,
               limit: newRl.limit,
               duration: newRl.duration,
             });
+          } else {
+            deleteRatelimits.push(rl);
           }
         }
         for (const newRl of req.ratelimits) {

apps/api/src/routes/v1_keys_getVerifications.ts

@@ -303,7 +303,7 @@ export const registerV1KeysGetVerifications = (app: App) =>
 function transformData(
   data: VerificationTimeseriesDataPoint[] | undefined,
 ): CacheNamespaces["verificationsByKeyId"] {
-  if (!data || !data.length) {
+  if (!data?.length) {
     return [];
   }
 

apps/api/src/routes/v1_migrations_createKey.ts

@@ -402,7 +402,7 @@ export const registerV1MigrationsCreateKeys = (app: App) =>
           });
         }
 
-        if (!key.hash && !key.plaintext) {
+        if (!(key.hash || key.plaintext)) {
           throw new UnkeyApiError({
             code: "BAD_REQUEST",
             message: "provide either `hash` or `plaintext`",

apps/api/src/routes/v1_ratelimits_deleteOverride.ts

@@ -66,7 +66,7 @@ export const registerV1RatelimitDeleteOverride = (app: App) =>
       c,
       buildUnkeyQuery(({ or }) => or("*", "ratelimit.*.delete_override")),
     );
-    if (!namespaceId && !namespaceName) {
+    if (!(namespaceId || namespaceName)) {
       throw new UnkeyApiError({
         code: "BAD_REQUEST",
         message: "You must provide a namespaceId or a namespaceName",

apps/api/src/routes/v1_ratelimits_getOverride.ts

@@ -72,7 +72,7 @@ export const registerV1RatelimitGetOverride = (app: App) =>
         message: "Missing required permission: ratelimit.*.read_override",
       });
     }
-    if (!namespaceId && !namespaceName) {
+    if (!(namespaceId || namespaceName)) {
       throw new UnkeyApiError({
         code: "BAD_REQUEST",
         message: "You must provide a namespaceId or a namespaceName",

apps/api/src/routes/v1_ratelimits_listOverrides.ts

@@ -74,7 +74,7 @@ export const registerV1RatelimitListOverrides = (app: App) =>
   app.openapi(route, async (c) => {
     const { namespaceId, namespaceName, limit, cursor } = c.req.valid("query");
     const { db } = c.get("services");
-    if (!namespaceId && !namespaceName) {
+    if (!(namespaceId || namespaceName)) {
       throw new UnkeyApiError({
         code: "BAD_REQUEST",
         message: "You must provide a namespaceId or a namespaceName",

apps/api/src/routes/v1_ratelimits_setOverride.ts

@@ -81,7 +81,7 @@ export type V1RatelimitSetOverrideResponse = z.infer<
 export const registerV1RatelimitSetOverride = (app: App) =>
   app.openapi(route, async (c) => {
     const req = c.req.valid("json");
-    if (!req.namespaceId && !req.namespaceName) {
+    if (!(req.namespaceId || req.namespaceName)) {
       throw new UnkeyApiError({
         code: "BAD_REQUEST",
         message: "You must provide a namespaceId or a namespaceName",

apps/dashboard/app/(app)/apis/[apiId]/_components/create-key/components/expiration-setup.tsx

@@ -123,8 +123,7 @@ export const ExpirationSetup = () => {
 
   // Calculate date for showing warning about close expiry (less than 1 hour)
   const isExpiringVerySoon =
-    currentExpiryDate &&
-    new Date(currentExpiryDate).getTime() - new Date().getTime() < 60 * 60 * 1000;
+    currentExpiryDate && new Date(currentExpiryDate).getTime() - Date.now() < 60 * 60 * 1000;
 
   const getExpiryDescription = () => {
     if (isExpiringVerySoon) {

apps/dashboard/app/(app)/apis/[apiId]/_components/create-key/components/metadata-setup.tsx

@@ -100,7 +100,7 @@ export const MetadataSetup = () => {
           rows={15}
           {...register("metadata.data", {
             validate: (value) => {
-              if (metadataEnabled && (!value || !validateJSON(value))) {
+              if (metadataEnabled && !(value && validateJSON(value))) {
                 return "Must be valid JSON";
               }
               return true;

apps/dashboard/app/(app)/apis/[apiId]/_components/create-key/create-key.schema.ts

@@ -209,7 +209,7 @@ export const expirationValidationSchema = z.object({
       })
       .refine(
         (date) => {
-          const minDate = new Date(new Date().getTime() + 2 * 60000);
+          const minDate = new Date(Date.now() + 2 * 60000);
           return date >= minDate;
         },
         {

apps/dashboard/app/(app)/apis/[apiId]/_components/create-key/create-key.utils.ts

@@ -48,13 +48,13 @@ export const formValuesToApiInput = (formValues: FormValues, keyAuthId: string):
 export const isFeatureEnabled = (sectionId: SectionName, values: FormValues): boolean => {
   switch (sectionId) {
     case "metadata":
-      return values.metadata?.enabled || false;
+      return Boolean(values.metadata?.enabled);
     case "ratelimit":
-      return values.ratelimit?.enabled || false;
+      return Boolean(values.ratelimit?.enabled);
     case "credits":
-      return values.limit?.enabled || false;
+      return Boolean(values.limit?.enabled);
     case "expiration":
-      return values.expiration?.enabled || false;
+      return Boolean(values.expiration?.enabled);
     case "general":
       return true;
     default:

apps/dashboard/app/(app)/apis/[apiId]/_components/create-key/hooks/use-fetch-identities/create-identity-options.tsx

@@ -65,7 +65,19 @@ export function createIdentityOptions({
                 Metadata
               </div>
               {/* Content - Different based on metadata presence */}
-              {!isMetaEmpty(identity.meta) ? (
+              {isMetaEmpty(identity.meta) ? (
+                <div className="px-2 py-2 flex-1">
+                  <div className="w-full bg-grayA-1 dark:bg-grayA-2 border rounded-lg border-grayA-5 overflow-hidden">
+                    <div className="flex items-start justify-between w-full gap-2">
+                      <div className="overflow-x-auto w-full min-w-0 p-3">
+                        <pre className="whitespace-pre-wrap break-all text-[11px] leading-5 text-gray-8 font-mono">
+                          No metadata available
+                        </pre>
+                      </div>
+                    </div>
+                  </div>
+                </div>
+              ) : (
                 <div className="px-2 py-2 flex-1 overflow-y-auto h-[270px]">
                   <div className="w-full bg-grayA-1 dark:bg-grayA-2 border rounded-lg border-grayA-5 overflow-hidden h-full">
                     <div className="flex items-start justify-between w-full gap-2 h-full">
@@ -90,18 +102,6 @@ export function createIdentityOptions({
                     </div>
                   </div>
                 </div>
-              ) : (
-                <div className="px-2 py-2 flex-1">
-                  <div className="w-full bg-grayA-1 dark:bg-grayA-2 border rounded-lg border-grayA-5 overflow-hidden">
-                    <div className="flex items-start justify-between w-full gap-2">
-                      <div className="overflow-x-auto w-full min-w-0 p-3">
-                        <pre className="whitespace-pre-wrap break-all text-[11px] leading-5 text-gray-8 font-mono">
-                          No metadata available
-                        </pre>
-                      </div>
-                    </div>
-                  </div>
-                </div>
               )}
             </div>
           </TooltipContent>

apps/dashboard/app/(app)/apis/[apiId]/_overview/components/controls/components/logs-datetime/index.tsx

@@ -67,17 +67,15 @@ export const LogsDateTime = () => {
       }}
       initialTitle={title ?? ""}
       onSuggestionChange={setTitle}
-      customOptions={DEFAULT_OPTIONS.filter(
-        (option) => !option.value || !option.value.endsWith("m"),
-      )}
+      customOptions={DEFAULT_OPTIONS.filter((option) => !option.value?.endsWith("m"))}
     >
       <div className="group">
         <Button
           variant="ghost"
           size="md"
           className={cn(
             "group-data-[state=open]:bg-gray-4 px-2 rounded-lg",
-            !title ? "opacity-50" : "",
+            title ? "" : "opacity-50",
             title !== "Last 12 hours" ? "bg-gray-4" : "",
           )}
           aria-label="Filter logs by time"

apps/dashboard/app/(app)/apis/[apiId]/_overview/hooks/use-filters.ts

@@ -46,7 +46,9 @@ export const useFilters = () => {
     const activeFilters: KeysOverviewFilterValue[] = [];
 
     for (const [field, value] of Object.entries(searchParams)) {
-      if (!Array.isArray(value) || !["keyIds", "names", "identities", "outcomes"].includes(field)) {
+      if (
+        !(Array.isArray(value) && ["keyIds", "names", "identities", "outcomes"].includes(field))
+      ) {
         continue;
       }
 

apps/dashboard/app/(app)/apis/[apiId]/actions.ts

@@ -20,7 +20,7 @@ export type ApiLayoutData = {
 
 export const fetchApiAndWorkspaceDataFromDb = async (apiId: string): Promise<ApiLayoutData> => {
   const { orgId } = await getAuth();
-  if (!apiId || !orgId) {
+  if (!(apiId && orgId)) {
     console.error("fetchApiLayoutDataFromDb: apiId or orgId is missing");
     notFound();
   }

apps/dashboard/app/(app)/apis/[apiId]/keys/[keyAuthId]/[keyId]/components/controls/components/logs-datetime/index.tsx

@@ -67,17 +67,15 @@ export const LogsDateTime = () => {
       }}
       initialTitle={title ?? ""}
       onSuggestionChange={setTitle}
-      customOptions={DEFAULT_OPTIONS.filter(
-        (option) => !option.value || !option.value.endsWith("m"),
-      )}
+      customOptions={DEFAULT_OPTIONS.filter((option) => !option.value?.endsWith("m"))}
     >
       <div className="group">
         <Button
           variant="ghost"
           size="md"
           className={cn(
             "group-data-[state=open]:bg-gray-4 px-2 rounded-lg",
-            !title ? "opacity-50" : "",
+            title ? "" : "opacity-50",
             title !== "Last 12 hours" ? "bg-gray-4" : "",
           )}
           aria-label="Filter logs by time"

apps/dashboard/app/(app)/apis/[apiId]/keys/[keyAuthId]/_components/components/table/components/actions/components/disable-key.tsx

@@ -66,10 +66,10 @@ export const UpdateKeyStatus = ({ keyDetails, isOpen, onClose }: UpdateKeyStatus
 
   const handleActionButtonClick = () => {
     // Only show confirmation popover for disabling
-    if (!isEnabling) {
-      setIsConfirmPopoverOpen(true);
-    } else {
+    if (isEnabling) {
       performStatusUpdate();
+    } else {
+      setIsConfirmPopoverOpen(true);
     }
   };
 

apps/dashboard/app/(app)/apis/[apiId]/keys/[keyAuthId]/_components/components/table/components/actions/components/edit-external-id/index.tsx

@@ -51,7 +51,7 @@ export const EditExternalId = ({
       return;
     }
 
-    if (!isConfirmPopoverOpen && !open) {
+    if (!(isConfirmPopoverOpen || open)) {
       onClose();
     }
   };
@@ -99,7 +99,7 @@ export const EditExternalId = ({
                   className="rounded-lg flex-1"
                   loading={updateKeyOwner.isLoading}
                   onClick={handleSubmit}
-                  disabled={!originalIdentityId && !selectedIdentityId}
+                  disabled={!(originalIdentityId || selectedIdentityId)}
                 >
                   Update External ID
                 </Button>

apps/dashboard/app/(app)/apis/[apiId]/keys/[keyAuthId]/_components/components/table/components/selection-controls/components/batch-edit-external-id.tsx

@@ -47,7 +47,7 @@ export const BatchEditExternalId = ({
       return;
     }
 
-    if (!isConfirmPopoverOpen && !open) {
+    if (!(isConfirmPopoverOpen || open)) {
       onClose();
     }
   };

apps/dashboard/app/(app)/apis/[apiId]/keys/[keyAuthId]/_components/components/table/hooks/use-keys-list-query.ts

@@ -24,7 +24,7 @@ export function useKeysListQuery({ keyAuthId }: UseKeysListQueryParams) {
     };
 
     filters.forEach((filter) => {
-      if (!keysListFilterFieldNames.includes(filter.field) || !params[filter.field]) {
+      if (!(keysListFilterFieldNames.includes(filter.field) && params[filter.field])) {
         return;
       }
 

apps/dashboard/app/(app)/apis/[apiId]/keys/[keyAuthId]/_components/components/table/keys-list.tsx

@@ -98,7 +98,7 @@ export const KeysList = ({
               ) : (
                 <>
                   {/* Show icon when not selected and not hovered */}
-                  {!isSelected && !isHovered && (
+                  {!(isSelected || isHovered) && (
                     // biome-ignore lint/complexity/noUselessFragments: <explanation>
                     <>
                       {identity ? (
@@ -279,7 +279,7 @@ export const KeysList = ({
       }
 
       // Early exit if we already found a mix
-      if (!allEnabled && !allDisabled) {
+      if (!(allEnabled || allDisabled)) {
         break;
       }
     }

apps/dashboard/app/(app)/apis/[apiId]/settings/components/delete-protection.tsx

@@ -140,17 +140,17 @@ export const DeleteProtection: React.FC<Props> = ({ api }) => {
                 : "Enable API Delete Protection"}
             </Button>
             <div className="font-normal text-[12px] text-gray-9 text-center">
-              This setting can be {!api.deleteProtection ? "disabled" : "re-enabled"} at any time
+              This setting can be {api.deleteProtection ? "re-enabled" : "disabled"} at any time
             </div>
           </div>
         }
       >
         <div className="flex flex-col gap-4">
           <p className="text-gray-11 text-[13px]">
             <span className="font-medium">Important: </span>
-            {!api.deleteProtection
-              ? "Enabling this prevents the API from being deleted. This setting can be disabled at any time. "
-              : "Disabling this allows API deletion. This setting can be re-enabled at any time. "}
+            {api.deleteProtection
+              ? "Disabling this allows API deletion. This setting can be re-enabled at any time. "
+              : "Enabling this prevents the API from being deleted. This setting can be disabled at any time. "}
             <InlineLink
               label="Learn more"
               href="https://www.unkey.com/docs/security/delete-protection"

apps/dashboard/app/(app)/apis/_components/controls/components/logs-datetime/index.tsx

@@ -73,7 +73,7 @@ export const LogsDateTime = () => {
           size="md"
           className={cn(
             "group-data-[state=open]:bg-gray-4 px-2 rounded-lg",
-            !title ? "opacity-50" : "",
+            title ? "" : "opacity-50",
             title !== "Last 12 hours" ? "bg-gray-4" : "",
           )}
           aria-label="Filter logs by time"

apps/dashboard/app/(app)/audit/components/controls/components/logs-datetime/index.tsx

@@ -73,7 +73,7 @@ export const LogsDateTime = () => {
           size="md"
           className={cn(
             "group-data-[state=open]:bg-gray-4 px-2 rounded-lg",
-            !title ? "opacity-50" : "",
+            title ? "" : "opacity-50",
             title !== "Last 12 hours" ? "bg-gray-4" : "",
           )}
           aria-label="Filter logs by time"

apps/dashboard/app/(app)/authorization/roles/[roleId]/page.tsx

@@ -64,7 +64,7 @@ export default async function RolePage(props: Props) {
       },
     },
   });
-  if (!role || !role.workspace) {
+  if (!role?.workspace) {
     return notFound();
   }
   if (role.workspace.orgId !== orgId) {

apps/dashboard/app/(app)/logs/components/controls/components/logs-datetime/index.tsx

@@ -73,7 +73,7 @@ export const LogsDateTime = () => {
           size="md"
           className={cn(
             "group-data-[state=open]:bg-gray-4 px-2 rounded-lg",
-            !title ? "opacity-50" : "",
+            title ? "" : "opacity-50",
             title !== "Last 12 hours" ? "bg-gray-4" : "",
           )}
           aria-label="Filter logs by time"

apps/dashboard/app/(app)/ratelimits/[namespaceId]/_overview/components/controls/components/logs-datetime/index.tsx

@@ -73,7 +73,7 @@ export const LogsDateTime = () => {
           size="md"
           className={cn(
             "group-data-[state=open]:bg-gray-4 px-2 rounded-lg",
-            !title ? "opacity-50" : "",
+            title ? "" : "opacity-50",
             title !== "Last 12 hours" ? "bg-gray-4" : "",
           )}
           aria-label="Filter logs by time"

apps/dashboard/app/(app)/ratelimits/[namespaceId]/logs/components/controls/components/logs-datetime/index.tsx

@@ -73,7 +73,7 @@ export const LogsDateTime = () => {
           size="md"
           className={cn(
             "group-data-[state=open]:bg-gray-4 px-2 rounded-lg",
-            !title ? "opacity-50" : "",
+            title ? "" : "opacity-50",
             title !== "Last 12 hours" ? "bg-gray-4" : "",
           )}
           aria-label="Filter logs by time"

apps/dashboard/app/(app)/ratelimits/_components/controls/components/logs-datetime/index.tsx

@@ -73,7 +73,7 @@ export const LogsDateTime = () => {
           size="md"
           className={cn(
             "group-data-[state=open]:bg-gray-4 px-2 rounded-lg",
-            !title ? "opacity-50" : "",
+            title ? "" : "opacity-50",
             title !== "Last 12 hours" ? "bg-gray-4" : "",
           )}
           aria-label="Filter logs by time"