-
Notifications
You must be signed in to change notification settings - Fork 605
refactor: RQ hook for ratelimits logs #3147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
33c8afd
refactor: RQ hook
ogzhanolguncu 0b6b931
feat: memoize timestamp for ratelimit queries
ogzhanolguncu a6f35e0
chore: remove unused code
ogzhanolguncu d300803
fix: add missing refresh
ogzhanolguncu f1072b0
docs: add jsdocs
ogzhanolguncu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
.../(app)/ratelimits/[namespaceId]/_overview/components/controls/components/logs-refresh.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
...d/app/(app)/ratelimits/[namespaceId]/logs/components/controls/components/logs-refresh.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| "use client"; | ||
|
|
||
| import { type ReactNode, createContext, useContext, useEffect, useState } from "react"; | ||
|
|
||
| let queryTimestamp = Date.now(); | ||
| let subscribers: ((timestamp: number) => void)[] = []; | ||
|
|
||
| export const refreshQueryTime = () => { | ||
| queryTimestamp = Date.now(); | ||
| subscribers.forEach((callback) => callback(queryTimestamp)); | ||
| return queryTimestamp; | ||
| }; | ||
|
|
||
| type QueryTimeContextType = { | ||
| queryTime: number; | ||
| refreshQueryTime: () => number; | ||
| }; | ||
|
|
||
| const QueryTimeContext = createContext<QueryTimeContextType | undefined>(undefined); | ||
|
|
||
| /** | ||
| * Provides a shared timestamp reference for data fetching operations. | ||
| * | ||
| * Prevents React Query and other data fetching mechanisms from triggering | ||
| * unnecessary refetches due to components generating new timestamps on each render. | ||
| * | ||
| * Without this utility, each component would: | ||
| * - Create its own `Date.now()` when mounted or re-rendered | ||
| * - Cause React Query to treat it as a new dependency and refetch | ||
| * - Result in different components showing data from inconsistent time windows | ||
| * | ||
| * | ||
| * ```tsx | ||
| * // In a data fetching hook | ||
| * const { queryTime } = useQueryTime(); | ||
| * | ||
| * // Use in query parameters | ||
| * const params = { | ||
| * startTime: queryTime - TIME_WINDOW, | ||
| * endTime: queryTime | ||
| * }; | ||
| * | ||
| * // Only refetches when explicitly refreshed | ||
| * const { data } = useQuery(['data', params], fetchData); | ||
| * ``` | ||
| * | ||
| * When you need to refresh all queries simultaneously: | ||
| * ```tsx | ||
| * const { refreshQueryTime } = useQueryTime(); | ||
| * | ||
| * // Updates timestamp for ALL components | ||
| * const handleRefresh = () => refreshQueryTime(); | ||
| * ``` | ||
| */ | ||
| export const QueryTimeProvider = ({ children }: { children: ReactNode }) => { | ||
| const [queryTime, setQueryTime] = useState(queryTimestamp); | ||
|
|
||
| useEffect(() => { | ||
| const callback = (newTimestamp: number) => setQueryTime(newTimestamp); | ||
| subscribers.push(callback); | ||
|
|
||
| return () => { | ||
| subscribers = subscribers.filter((cb) => cb !== callback); | ||
| }; | ||
| }, []); | ||
|
|
||
| return ( | ||
| <QueryTimeContext.Provider value={{ queryTime, refreshQueryTime }}> | ||
| {children} | ||
| </QueryTimeContext.Provider> | ||
| ); | ||
| }; | ||
|
|
||
| export const useQueryTime = () => { | ||
| const context = useContext(QueryTimeContext); | ||
| if (context === undefined) { | ||
| throw new Error("useQueryTime must be used within a QueryTimeProvider"); | ||
| } | ||
| return context; | ||
| }; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.