-
Notifications
You must be signed in to change notification settings - Fork 607
feat: show timerange on chart tooltip #2985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
b645437
feat: show range on char tooltip
ogzhanolguncu dd9cdb0
Merge branch 'main' of github.com:unkeyed/unkey into show-timerange-c…
ogzhanolguncu f8a96f4
fix: typo
ogzhanolguncu 5de2992
fix: typo
ogzhanolguncu a206bf1
[autofix.ci] apply automated fixes
autofix-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| // components/logs/chart/utils/format-interval.ts | ||
|
|
||
| import { formatTimestampTooltip } from "../chart/utils/format-timestamp"; | ||
| import type { TimeseriesData } from "./types"; | ||
|
|
||
| /** | ||
| * Creates a tooltip formatter that displays time intervals between data points | ||
| * | ||
| * @param data - The chart data array containing timestamp information | ||
| * @returns A formatter function for use with chart tooltips | ||
| */ | ||
| export function createTimeIntervalFormatter(data?: TimeseriesData[]) { | ||
| return (tooltipPayload: any[]) => { | ||
| // Basic validation checks | ||
| if (!tooltipPayload?.[0]?.payload) { | ||
| return ""; | ||
| } | ||
|
|
||
| const currentPayload = tooltipPayload[0].payload; | ||
| const currentTimestamp = currentPayload.originalTimestamp; | ||
| const currentDisplayX = currentPayload.displayX; | ||
|
|
||
| // If we don't have necessary data, fallback to displaying just the current point | ||
| if (!currentTimestamp || !currentDisplayX || !data?.length) { | ||
| return ( | ||
| <div> | ||
| <span className="font-mono text-accent-9 text-xs px-4"> | ||
| {currentDisplayX || formatTimestampTooltip(currentTimestamp)} | ||
| </span> | ||
| </div> | ||
| ); | ||
| } | ||
|
|
||
| // Find position in the data array | ||
| const currentIndex = data.findIndex((item) => item?.originalTimestamp === currentTimestamp); | ||
|
|
||
| // If this is the last item or not found, just show current timestamp | ||
| if (currentIndex === -1 || currentIndex >= data.length - 1) { | ||
| return ( | ||
| <div> | ||
| <span className="font-mono text-accent-9 text-xs px-4">{currentDisplayX}</span> | ||
| </div> | ||
| ); | ||
| } | ||
|
|
||
| // Get the next point in the sequence | ||
| const nextPoint = data[currentIndex + 1]; | ||
| if (!nextPoint) { | ||
| return ( | ||
| <div> | ||
| <span className="font-mono text-accent-9 text-xs px-4">{currentDisplayX}</span> | ||
| </div> | ||
| ); | ||
| } | ||
|
|
||
| // Format the next timestamp | ||
| const nextDisplayX = | ||
| nextPoint.displayX || | ||
| (nextPoint.originalTimestamp ? formatTimestampTooltip(nextPoint.originalTimestamp) : ""); | ||
|
|
||
| // Return formatted interval | ||
| return ( | ||
| <div> | ||
| <span className="font-mono text-accent-9 text-xs px-4"> | ||
| {currentDisplayX} - {nextDisplayX} | ||
| </span> | ||
| </div> | ||
| ); | ||
| }; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.