Skip to content

fix: format apis overview numbers #2930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chronark merged 3 commits into from
Mar 3, 2025
Merged

fix: format apis overview numbers #2930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8d4fe36
fix: format number issue and make cards bigger
ogzhanolguncu Mar 3, 2025
9fe134b
refactor: apply same grid structure to ratelimits page
ogzhanolguncu Mar 3, 2025
ef03bef
chore: fmt
ogzhanolguncu Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/dashboard/app/(app)/ratelimits/_components/ratelimit-client.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export const RatelimitClient = ({
<RatelimitListControlCloud />

{namespaces.length > 0 ? (
<div className="grid grid-cols-1 sm:grid-cols-2 md:grid-cols-2 lg:grid-cols-3 xl:grid-cols-4 2xl:grid-cols-5 gap-3 md:gap-5 w-full p-5">
<div className="grid grid-cols-1 md:grid-cols-2 xl:grid-cols-3 2xl:grid-cols-4 gap-3 md:gap-5 w-full p-5">
{namespaces.map((namespace) => (
<NamespaceCard namespace={namespace} key={namespace.id} />
))}
Expand Down
6 changes: 4 additions & 2 deletions apps/dashboard/components/stats-card/components/metric-stats.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import { formatNumber } from "@/lib/fmt";

export const MetricStats = ({
successCount,
errorCount,
Expand All @@ -13,14 +15,14 @@ export const MetricStats = ({
<div className="flex flex-col gap-1">
<div className="flex gap-2 items-center">
<div className="bg-accent-8 rounded h-[10px] w-1" />
<div className="text-accent-12 text-xs font-medium">{successCount}</div>
<div className="text-accent-12 text-xs font-medium">{formatNumber(successCount)}</div>
<div className="text-accent-9 text-[11px] leading-4">{successLabel}</div>
</div>
</div>
<div className="flex flex-col gap-1">
<div className="flex gap-2 items-center">
<div className="bg-orange-9 rounded h-[10px] w-1" />
<div className="text-accent-12 text-xs font-medium">{errorCount}</div>
<div className="text-accent-12 text-xs font-medium">{formatNumber(errorCount)}</div>
<div className="text-accent-9 text-[11px] leading-4">{errorLabel}</div>
</div>
</div>
Expand Down
17 changes: 8 additions & 9 deletions apps/dashboard/components/stats-card/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,16 +25,16 @@ export const StatsCard = ({
}: StatsCardProps) => {
return (
<div className="flex flex-col border border-gray-6 rounded-xl overflow-hidden">
<div className="h-[120px]">{chart}</div>
<div className="h-[140px]">{chart}</div>
<Link href={linkPath}>
<div className="p-4 md:p-6 border-t border-gray-6 flex flex-col gap-1">
<div className="flex justify-between items-center flex-wrap">
<div className="flex flex-col">
<div className="p-4 md:p-6 border-t border-gray-6 flex flex-col gap-2">
<div className="flex justify-between items-center">
<div className="flex flex-col flex-grow min-w-0">
<div className="flex gap-2 md:gap-3 items-center">
<span className="flex-shrink-0">{icon}</span>
<Tooltip>
<TooltipTrigger>
<div className="text-accent-12 font-semibold truncate w-[180px] text-left">
<div className="text-accent-12 font-semibold truncate w-[220px] md:w-[280px] text-left">
{name}
</div>
</TooltipTrigger>
Expand All @@ -46,7 +46,7 @@ export const StatsCard = ({
{secondaryId && (
<Tooltip>
<TooltipTrigger>
<div className="text-left text-accent-11 text-xxs overflow-hidden text-ellipsis max-w-full w-[200px]">
<div className="text-left text-accent-11 text-xxs overflow-hidden text-ellipsis w-[240px] md:w-[300px]">
{secondaryId}
</div>
</TooltipTrigger>
Expand All @@ -56,10 +56,9 @@ export const StatsCard = ({
</Tooltip>
)}
</div>
{rightContent && <div className="flex-shrink-0 ml-auto">{rightContent}</div>}
{rightContent && <div className="flex-shrink-0">{rightContent}</div>}
</div>

<div className="flex items-center w-full justify-between gap-3 md:gap-4 mt-2 flex-wrap">
<div className="flex items-center w-full justify-between gap-3 md:gap-4 mt-2">
{stats}
</div>
</div>
Expand Down