Skip to content

fix: ENG-1637: Unifiy Byte length across the menu #2920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chronark merged 3 commits into from
Feb 27, 2025
Merged

fix: ENG-1637: Unifiy Byte length across the menu #2920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9af363a
ENG-1637: Fix byte length
perkinsjr Feb 26, 2025
2f722ca
fmt
perkinsjr Feb 26, 2025
b1d892f
remove line
perkinsjr Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/dashboard/app/(app)/apis/[apiId]/keys/[keyAuthId]/new/client.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ export const CreateKey = ({ apiId, keyAuthId, defaultBytes, defaultPrefix }: Pro
},
onError(err) {
console.error(err);
toast.error(err.message);
toast.error(err.message || "An unknown error occurred");
},
});

Expand Down
7 changes: 3 additions & 4 deletions apps/dashboard/app/(app)/apis/[apiId]/keys/[keyAuthId]/new/validation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,11 @@ export const formSchema = z.object({
.number({
errorMap: (issue, { defaultError }) => ({
message:
issue.code === "invalid_type"
? "Amount must be a number and greater than 0"
: defaultError,
issue.code === "invalid_type" ? "Key must be between 8 and 255 bytes long" : defaultError,
}),
})
.min(16)
.min(8, { message: "Key must be between 8 and 255 bytes long" })
.max(255, { message: "Key must be between 8 and 255 bytes long" })
.default(16),
prefix: z
.string()
Expand Down
4 changes: 2 additions & 2 deletions apps/dashboard/app/(app)/apis/[apiId]/settings/default-bytes.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ const formSchema = z.object({
keyAuthId: z.string(),
defaultBytes: z
.number()
.min(16, "Byte size needs to be at least 16")
.max(255, "Byte size cannot exceed 255")
.min(8, "Key must be between 8 and 255 bytes long")
.max(255, "Key must be between 8 and 255 bytes long")
.optional(),
});

Expand Down
7 changes: 6 additions & 1 deletion apps/dashboard/lib/trpc/routers/key/create.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,12 @@ export const createKey = t.procedure
message: "Prefixes cannot contain spaces.",
})
.optional(),
bytes: z.number().int().gte(16).default(16),
bytes: z
.number()
.int()
.min(8, { message: "Key must be between 8 and 255 bytes long" })
.max(255, { message: "Key must be between 8 and 255 bytes long" })
.default(16),
keyAuthId: z.string(),
ownerId: z.string().nullish(),
meta: z.record(z.unknown()).optional(),
Expand Down
Loading