Skip to content

fix: Client-side exception occurs when adding a filter to rate limit logs table with no data #2542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chronark merged 17 commits into from
Oct 29, 2024
Merged

fix: Client-side exception occurs when adding a filter to rate limit logs table with no data #2542

Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
0a496f0
fix:changed the permission view
RajuGangitla Oct 6, 2024
dd0bb12
Merge branch 'main' of https://github.com/RajuGangitla/unkey
RajuGangitla Oct 6, 2024
f4f2944
Merge branch 'unkeyed:main' into main
RajuGangitla Oct 7, 2024
fcc6a2e
Merge branch 'main' into main
RajuGangitla Oct 7, 2024
c81f329
Merge branch 'unkeyed:main' into main
RajuGangitla Oct 8, 2024
5dd0fb9
Merge branch 'unkeyed:main' into main
RajuGangitla Oct 8, 2024
a0d8e88
fixed issue comments
RajuGangitla Oct 8, 2024
66e39d0
Merge branch 'unkeyed:main' into main
RajuGangitla Oct 10, 2024
4b69b5b
Merge branch 'main' into main
chronark Oct 10, 2024
6846063
[autofix.ci] apply automated fixes
autofix-ci[bot] Oct 10, 2024
b4531a8
Merge branch 'unkeyed:main' into main
RajuGangitla Oct 13, 2024
f48eb86
removed font
RajuGangitla Oct 13, 2024
5609bbc
Merge branch 'main' into main
RajuGangitla Oct 13, 2024
eac3e14
Merge branch 'main' into main
chronark Oct 17, 2024
f43f5d8
Merge branch 'unkeyed:main' into main
RajuGangitla Oct 18, 2024
7b4ba95
Merge branch 'unkeyed:main' into main
RajuGangitla Oct 23, 2024
68b98f5
added default value
RajuGangitla Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/dashboard/components/array-input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ type Props = {
setSelected: (v: string[]) => void;
};

export const ArrayInput: React.FC<Props> = ({ title, placeholder, selected, setSelected }) => {
export const ArrayInput: React.FC<Props> = ({ title, placeholder, selected = [], setSelected }) => {
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Consider making the selected prop optional in the Props type.

While adding a default value for selected fixes the "undefined is not iterable" error, there's a slight inconsistency in the type definition. The selected prop is marked as required in the Props type but has a default value in the component signature.

Consider updating the Props type to match the runtime behavior:

type Props = {
  title?: string;
  placeholder?: string;
-  selected: string[];
+  selected?: string[];
  setSelected: (v: string[]) => void;
};
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
export const ArrayInput: React.FC<Props> = ({ title, placeholder, selected = [], setSelected }) => {
type Props = {
title?: string;
placeholder?: string;
selected?: string[];
setSelected: (v: string[]) => void;
};

const inputRef = React.useRef<HTMLInputElement>(null);
const [inputValue, setInputValue] = React.useState("");

Expand Down