Skip to content

fix: reset form values for delete role and delete permission dialogs #2529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ChaseNelson wants to merge 4 commits into from
Closed

fix: reset form values for delete role and delete permission dialogs #2529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0901a95
fix: updates delete-role dialog to reset form on open change
ChaseNelson Oct 21, 2024
8cc64bd
fix: updates delete-permission dialog to reset form on open change
ChaseNelson Oct 21, 2024
9411615
Merge branch 'main' into fix/delete-dialogs-input-values
ChaseNelson Oct 24, 2024
4fc41b4
Merge branch 'main' into fix/delete-dialogs-input-values
chronark Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions apps/dashboard/app/(app)/authorization/permissions/[permissionId]/delete-permission.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,11 @@ export const DeletePermission: React.FC<Props> = ({ trigger, permission }) => {
},
});

function handleDialogOpenChange(newState: boolean) {
setOpen(newState);
form.reset();
}
Comment on lines +67 to +70
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot Oct 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Remove duplicate function definition.

The handleDialogOpenChange function is defined twice with identical implementation. This appears to be a merge or copy-paste error.

Remove one of the duplicate function definitions:

-  function handleDialogOpenChange(newState: boolean) {
-    setOpen(newState);
-    form.reset();
-  }

Also applies to: 77-80

🧰 Tools
🪛 Biome

[error] 67-67: This function is unused.

Unused variables usually are result of incomplete refactoring, typos and other source of bugs.

(lint/correctness/noUnusedVariables)


async function onSubmit() {
deletePermission.mutate({ permissionId: permission.id });
}
Expand Down
5 changes: 5 additions & 0 deletions apps/dashboard/app/(app)/authorization/roles/[roleId]/delete-role.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,11 @@ export const DeleteRole: React.FC<Props> = ({ trigger, role }) => {
},
});

function handleDialogOpenChange(newState: boolean) {
setOpen(newState);
form.reset();
}
Comment on lines +68 to +71
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot Oct 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Remove duplicate function declaration.

The handleDialogOpenChange function is declared twice in the component. Remove the first declaration to fix the error.

- function handleDialogOpenChange(newState: boolean) {
-   setOpen(newState);
-   form.reset();
- }

Also applies to: 101-104

🧰 Tools
🪛 Biome

[error] 68-68: This function is unused.

Unused variables usually are result of incomplete refactoring, typos and other source of bugs.

(lint/correctness/noUnusedVariables)


async function onSubmit() {
deleteRole.mutate({ roleId: role.id });
}
Expand Down