Skip to content

fix: Workspace Permissions overlaps with their descriptions on smaller windows #2127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chronark merged 15 commits into from
Oct 3, 2024
Merged

fix: Workspace Permissions overlaps with their descriptions on smaller windows #2127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
54eecf9
Responsiveness problem on new rootkey
harshsbhat Sep 24, 2024
900be73
Changes
harshsbhat Sep 24, 2024
46c1af6
Merge branch 'main' into harshbhat/permissions-smallScreen
harshsbhat Sep 24, 2024
8194e8e
Changes
harshsbhat Sep 24, 2024
ea9bf96
Merge branch 'main' into harshbhat/permissions-smallScreen
harshsbhat Sep 24, 2024
3b443bb
Merge branch 'main' into harshbhat/permissions-smallScreen
harshsbhat Sep 25, 2024
b68361b
Vertically align on phone
harshsbhat Sep 25, 2024
81571b0
Merge branch 'main' into harshbhat/permissions-smallScreen
harshsbhat Sep 26, 2024
48af0b0
Adding back items-center and some other minor changes
harshsbhat Sep 26, 2024
83927fe
Merge branch 'main' into harshbhat/permissions-smallScreen
harshsbhat Sep 26, 2024
e8d42c6
Merge branch 'main' into harshbhat/permissions-smallScreen
harshsbhat Sep 26, 2024
1cc4c26
Fixing the alignment
harshsbhat Sep 26, 2024
edab6ec
Merge branch 'main' into harshbhat/permissions-smallScreen
harshsbhat Oct 3, 2024
39b09b5
Center aligned
harshsbhat Oct 3, 2024
a8afac8
[autofix.ci] apply automated fixes
autofix-ci[bot] Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions apps/dashboard/app/(app)/settings/root-keys/new/client.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,8 +194,10 @@ export const Client: React.FC<Props> = ({ apis }) => {
<div className="flex flex-col">
<PermissionToggle
permissionName={`selectAll-${category}`}
label={<span className="text-base font-bold">{category}</span>}
description={`Select all for ${category} permissions for this API`}
label={
<span className="text-base font-bold mt-3.5 sm:mt-0">{category}</span>
}
description={`Select all ${category} permissions for this API`}
checked={isAllSelected}
setChecked={(isChecked) => {
allPermissionNames.forEach((permission) => {
Expand Down Expand Up @@ -304,8 +306,8 @@ const PermissionToggle: React.FC<PermissionToggleProps> = ({
description,
}) => {
return (
<div className="flex items-center gap-0">
<div className="w-1/3 ">
<div className="flex flex-col sm:items-center gap-1 mb-2 sm:flex-row sm:gap-0 sm:mb-0">
<div className="w-1/3">
<Tooltip>
<TooltipTrigger className="flex items-center gap-2">
<Checkbox
Expand All @@ -324,7 +326,7 @@ const PermissionToggle: React.FC<PermissionToggleProps> = ({
</Tooltip>
</div>

<p className="w-2/3 text-xs text-content-subtle">{description}</p>
<p className="w-full md:w-2/3 text-xs text-content-subtle ml-6 md:ml-0">{description}</p>
</div>
);
};
11 changes: 2 additions & 9 deletions packages/api/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,19 +9,12 @@
"publishConfig": {
"access": "public"
},
"keywords": [
"unkey",
"client",
"api"
],
"keywords": ["unkey", "client", "api"],
"bugs": {
"url": "https://github.com/unkeyed/unkey/issues"
},
"homepage": "https://github.com/unkeyed/unkey#readme",
"files": [
"./dist/**",
"README.md"
],
"files": ["./dist/**", "README.md"],
"author": "Andreas Thomas <andreas@chronark.com>",
"scripts": {
"generate": "openapi-typescript https://api.unkey.dev/openapi.json -o ./src/openapi.d.ts",
Expand Down
11 changes: 2 additions & 9 deletions packages/hono/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,19 +8,12 @@
"publishConfig": {
"access": "public"
},
"keywords": [
"unkey",
"client",
"api",
"hono"
],
"keywords": ["unkey", "client", "api", "hono"],
"bugs": {
"url": "https://github.com/unkeyed/unkey/issues"
},
"homepage": "https://github.com/unkeyed/unkey#readme",
"files": [
"./dist/**"
],
"files": ["./dist/**"],
"author": "Andreas Thomas <andreas@chronark.com>",
"scripts": {
"build": "tsup",
Expand Down
10 changes: 2 additions & 8 deletions packages/nextjs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,18 +8,12 @@
"publishConfig": {
"access": "public"
},
"keywords": [
"unkey",
"client",
"api"
],
"keywords": ["unkey", "client", "api"],
"bugs": {
"url": "https://github.com/unkeyed/unkey/issues"
},
"homepage": "https://github.com/unkeyed/unkey#readme",
"files": [
"./dist/**"
],
"files": ["./dist/**"],
"author": "Andreas Thomas <andreas@chronark.com>",
"scripts": {
"build": "tsup"
Expand Down
11 changes: 2 additions & 9 deletions packages/ratelimit/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,19 +9,12 @@
"publishConfig": {
"access": "public"
},
"keywords": [
"unkey",
"ratelimit",
"global",
"serverless"
],
"keywords": ["unkey", "ratelimit", "global", "serverless"],
"bugs": {
"url": "https://github.com/unkeyed/unkey/issues"
},
"homepage": "https://github.com/unkeyed/unkey#readme",
"files": [
"./dist/**"
],
"files": ["./dist/**"],
"author": "Andreas Thomas <andreas@unkey.dev>",
"scripts": {
"build": "tsup"
Expand Down