-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support parallel builds #461
base: main
Are you sure you want to change the base?
Conversation
Thanks for PR. However it might be beneficial, it causes a behavior change and can potentially breaks projects (for example if result of first mkdist is needed for second rollup, for types, etc) Can you please move it behind a flag like |
Hi! I'm autofix.ci, a bot that automatically fixes trivial issues such as code formatting in pull requests. I would like to apply some automated changes to this pull request, but it looks like I don't have the necessary permissions to do so. To get this pull request into a mergeable state, please do one of the following two things:
|
Thank you so much for your suggestion! Based on your advice, I’ve added a flag: parallel, which defaults to false and is provided as an experimental feature. 🙏🏼 |
src/build.ts
Outdated
// rollup | ||
rollupBuild(ctx), | ||
// copy | ||
copyBuild(ctx), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is almost correct however we need to do something like ()=>copybuild(ctx) here because otherwise regardless of awaiting or not, they will be started immediately in parallel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I was careless—it's already fixed now.
No description provided.