Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support parallel builds #461

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Sunny-117
Copy link
Contributor

No description provided.

@pi0 pi0 changed the title chore: prefer parallel build feat: support parallel builds Dec 23, 2024
@pi0
Copy link
Member

pi0 commented Dec 23, 2024

Thanks for PR. However it might be beneficial, it causes a behavior change and can potentially breaks projects (for example if result of first mkdist is needed for second rollup, for types, etc)

Can you please move it behind a flag like parallel: true? 🙏🏼

Copy link
Contributor

autofix-ci bot commented Dec 24, 2024

Hi! I'm autofix logoautofix.ci, a bot that automatically fixes trivial issues such as code formatting in pull requests.

I would like to apply some automated changes to this pull request, but it looks like I don't have the necessary permissions to do so. To get this pull request into a mergeable state, please do one of the following two things:

  1. Allow edits by maintainers for your pull request, and then re-trigger CI (for example by pushing a new commit).
  2. Manually fix the issues identified for your pull request (see the GitHub Actions output for details on what I would like to change).

@Sunny-117
Copy link
Contributor Author

Thanks for PR. However it might be beneficial, it causes a behavior change and can potentially breaks projects (for example if result of first mkdist is needed for second rollup, for types, etc)

Can you please move it behind a flag like parallel: true? 🙏🏼

Thank you so much for your suggestion! Based on your advice, I’ve added a flag: parallel, which defaults to false and is provided as an experimental feature. 🙏🏼

src/build.ts Outdated
// rollup
rollupBuild(ctx),
// copy
copyBuild(ctx),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is almost correct however we need to do something like ()=>copybuild(ctx) here because otherwise regardless of awaiting or not, they will be started immediately in parallel

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I was careless—it's already fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants