Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: update to rollup 4 #327

Merged
merged 3 commits into from
Oct 30, 2023
Merged

feat!: update to rollup 4 #327

merged 3 commits into from
Oct 30, 2023

Conversation

sapphi-red
Copy link
Contributor

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR updates rollup to v4 and updates rollup plugins to a version that supports that.
https://github.com/rollup/rollup/blob/master/CHANGELOG.md#400

Because rollup v4 now preserves shebang comments, I changed the code related to that.
https://github.com/rollup/rollup/blob/master/CHANGELOG.md#400:~:text=If%20an%20entry%20module%20starts%20with%20a%20shebang%20comment%20%23!...%2C%20this%20comment%20will%20be%20prepended%20to%20the%20output%20for%20es%20and%20cjs%20formats%20(%235163)

close #326

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work ❀️ Tested locally and all looks perfectly working!

@pi0 pi0 merged commit 2078880 into unjs:main Oct 30, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants