Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pkg): fix ts type resolution for /node subpath #256

Merged
merged 4 commits into from
Aug 16, 2023
Merged

fix(pkg): fix ts type resolution for /node subpath #256

merged 4 commits into from
Aug 16, 2023

Conversation

tmkx
Copy link
Contributor

@tmkx tmkx commented Jul 20, 2023

πŸ”— Linked issue

close #251

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)

πŸ“š Description

Sorry for the previous PR, I didn't know if the type was necessary, so I made a simple fix that removed it.

there is an awesome tool to check exports https://arethetypeswrong.github.io/ :

Before After

References: Masquerading as ESM

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #256 (330658c) into main (f5d94fa) will decrease coverage by 1.27%.
The diff coverage is n/a.

❗ Current head 330658c differs from pull request most recent head 9d2258f. Consider uploading reports for the commit 9d2258f to get more accurate results

@@            Coverage Diff             @@
##             main     #256      +/-   ##
==========================================
- Coverage   91.73%   90.47%   -1.27%     
==========================================
  Files           5        5              
  Lines         472      462      -10     
  Branches       79       74       -5     
==========================================
- Hits          433      418      -15     
- Misses         39       44       +5     

see 1 file with indirect coverage changes

@pi0 pi0 changed the title fix: fix ts type resolution fix: fix ts type resolution for /node subpath Jul 21, 2023
@pi0 pi0 requested a review from danielroe August 16, 2023 15:05
@pi0 pi0 changed the title fix: fix ts type resolution for /node subpath fix(pkg): fix ts type resolution for /node subpath Aug 16, 2023
@pi0
Copy link
Member

pi0 commented Aug 16, 2023

Thanks!

@pi0 pi0 merged commit 19b79fa into unjs:main Aug 16, 2023
@tmkx tmkx deleted the fix/ts-resolution branch August 16, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The type declarations are not compatible with NodeNext
3 participants