Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade to [email protected] #231

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SethFalco
Copy link
Contributor

@SethFalco SethFalco commented Jun 11, 2024

Reference: N/A

Note: this PR should not be merged yet. SVGO v4 is still a release candidate for now. I just wanted to help with migrating, and to review the migration to SVGO v4 to see if there'd be any regressions downstream that we didn't spot in our testing.

Summary

Migrate to SVGO v4.

  • SVGO is now an ESM module. (Common JS is still supported.)
  • removeViewBox and removeTitle are no longer part of preset-default.
    • we disabled removeViewBox to preserve scalability (can be enabled via SVGO config)
    • we disabled removeTitle to preserve accessibility (can be enabled via SVGO config)
  • Renames removeScriptElement to removeScripts (in v4.0.0-rc.1, we internally rewrite the old name to the new one, so this shouldn't be a breaking change for you, even if users including the plugin themselves in the options)

Changes

In your project, I think this changes virtually nothing, actually. It's just nice to use the recent name for removeScripts to avoid the alias warning.

@SethFalco SethFalco changed the title chore(deps)!: upgrade to [email protected] chore(deps): upgrade to [email protected] Jun 11, 2024
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.02%. Comparing base (f666cb4) to head (f2e8e38).
Report is 14 commits behind head on main.

Files Patch % Lines
src/ipx.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #231   +/-   ##
=======================================
  Coverage   56.02%   56.02%           
=======================================
  Files          14       14           
  Lines        1203     1203           
  Branches       83       84    +1     
=======================================
  Hits          674      674           
  Misses        526      526           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi0
Copy link
Member

pi0 commented Mar 21, 2025

Hi dear @SethFalco I hope you are doing well. Do you know have any plans for svgo v4?

@SethFalco
Copy link
Contributor Author

I've just been too busy to work on SVGO for the past few months. ^-^'

I need to release the next release candidate by this weekend, and fix a few minor issues that have been reported. There are still plans to do a v4 release, but it was delayed unfortunately as I prioritized paid work.

Sorry to leave you with a stale PR, meanwhile!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants