Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add h3 middleware example #144

Merged
merged 5 commits into from
Sep 5, 2023
Merged

Conversation

oritwoen
Copy link
Contributor

I was a bit surprised that the only example of middleware is express, especially that in the unjs ecosystem there is a super h3.

I recently created my own CDN so I am also adding information for others.

README.md Show resolved Hide resolved
@atinux atinux requested a review from pi0 July 25, 2023 14:33
README.md Outdated Show resolved Hide resolved
@pi0 pi0 added the v1 label Sep 5, 2023
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #144 (881581e) into main (9ed2708) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #144   +/-   ##
=======================================
  Coverage   56.75%   56.75%           
=======================================
  Files          10       10           
  Lines         948      948           
  Branches       41       41           
=======================================
  Hits          538      538           
  Misses        410      410           

@pi0
Copy link
Member

pi0 commented Sep 5, 2023

Thanks for the PR dear @oritwoen and sorry took long to review.

IPX was made before H3 and therefore middleware format is express friendly. I am going to work on v2 with h3-first API support but in the meantime, added little updates to your examples to merged it to main docs 👍🏼

@pi0 pi0 merged commit b03e2b9 into unjs:main Sep 5, 2023
@oritwoen oritwoen deleted the docs/h3-middleware branch September 5, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants