Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(examples): add cors example #700

Merged
merged 1 commit into from
Jun 17, 2024
Merged

docs(examples): add cors example #700

merged 1 commit into from
Jun 17, 2024

Conversation

zauni
Copy link
Contributor

@zauni zauni commented Mar 12, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Add an example on how to use the "handleCors" function.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Question: Should be there more examples for the other CORS related functions like "appendCorsHeaders" etc.?

@zauni
Copy link
Contributor Author

zauni commented Jun 2, 2024

Is there something I can do to bring this PR further? Maybe the example is even completely wrong? πŸ™‚ But then, how is CORS supposed to be used correctly?

@pi0 pi0 changed the title docs(examples): add CORS example docs(examples): add cors example Jun 17, 2024
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit 452a7bd into unjs:main Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants