Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(proxy): add additional test to make sure json response is sent as is #512

Merged
merged 1 commit into from
Aug 20, 2023

Conversation

Aareksio
Copy link
Contributor

πŸ”— Linked issue

nitrojs/nitro#1605

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This is a passing test to confirm the issue with proxy applying pretty-print to JSON is caused by downstream (nitro).

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Aug 19, 2023

Codecov Report

Merging #512 (3e062d6) into main (8af0474) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #512   +/-   ##
=======================================
  Coverage   82.11%   82.11%           
=======================================
  Files          31       31           
  Lines        3646     3646           
  Branches      536      539    +3     
=======================================
  Hits         2994     2994           
  Misses        652      652           

@pi0 pi0 changed the title chore(test): test JSON proxy transparency test(proxy): add additional test to make sure json response is sent as is Aug 20, 2023
@pi0 pi0 merged commit a3ad8c2 into unjs:main Aug 20, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants