Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support cleanup hook #64

Merged
merged 5 commits into from
Sep 9, 2023
Merged

feat: support cleanup hook #64

merged 5 commits into from
Sep 9, 2023

Conversation

Barbapapazes
Copy link
Member

πŸ”— Linked issue

fix #63

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR implements the cleanup function defines in types.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@Barbapapazes Barbapapazes self-assigned this Sep 5, 2023
@Barbapapazes Barbapapazes requested a review from pi0 September 5, 2023 21:24
src/command.ts Outdated Show resolved Hide resolved
@Barbapapazes Barbapapazes requested a review from pi0 September 5, 2023 21:52
@pi0
Copy link
Member

pi0 commented Sep 9, 2023

Thanks! It seems without catch/rethrow cleanup also get's called so i have simplified it (if i am assuming wrong, feel free to open another PR to amend changes πŸ‘πŸΌ )

@pi0 pi0 merged commit 416cd8f into main Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cleanup is just a type
2 participants