Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not throw error when no subcommand specified but main has run #58

Merged
merged 1 commit into from
Sep 9, 2023
Merged

fix: do not throw error when no subcommand specified but main has run #58

merged 1 commit into from
Sep 9, 2023

Conversation

sxzz
Copy link
Member

@sxzz sxzz commented Aug 26, 2023

πŸ”— Linked issue

closes #35

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Fixes emitting an error when there's main command and sub-commands

 ERROR  Unknown command undefined

Reproduction:

const validate = defineCommand({
  run() {
    console.log('run')
  },
})

const main = defineCommand({
  meta: {
    name,
    version,
    description,
  },
  subCommands: {
    validate,
  },
  run() {
    console.log('run main')
  },
})

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for detailed PR and sorry took long to review ❀️

@pi0 pi0 changed the title fix: error when no sub command fix: do not throw error when no subcommand specified but main has run Sep 9, 2023
@pi0 pi0 merged commit ed7efca into unjs:main Sep 9, 2023
@pi0
Copy link
Member

pi0 commented Sep 9, 2023

I am thinking as a relevant fix, only run cmd.run when there is no sub-command wdyt?

@sxzz sxzz deleted the fix/no-sub-command branch September 9, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subcommand matching logic error
2 participants