feat(command): return result of run command #101
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
β Type of change
π Description
Changes
This will return the result of the
run
function of the command being executed.Why is this needed?
Sometimes a command may return some output or something. It would be nice to be able to get this result.
Please see this related PR I submitted to the Nuxt
nuxi
CLI. They are usingrunCommand
fromcitty
here: https://github.com/nuxt/cli/blob/3401917c1852918171e23013d6522bda31762e5d/src/run.ts#L33And they are returning the result or
runCommand
like this:now, if the command they are calling/running returns something, it would be lost, since
runCommand
does not return anything as it is.I hope this change makes sense. We need it in Nx, but in any case I think it could benefit others as well.
π Checklist