Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made some typographical corrections and fixed some Markdown syntax errors.d #1950

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

tonywald
Copy link
Contributor

Description

Fixed the Markdown syntax for Github last commit tag on line 280.

Fixed the Markdown syntax for eza-ls link on line 944.

Modified description for terminal-aliases plugin on line 1457 to indicate that terraform and git are commands here and not other plugins.

Removed an extraneous "]" on line 1671.

Fixed the Markdown syntax for robbyrussell theme link on line 2201.

Type of changes

  • A link to an external resource like a blog post
  • Add/remove/update a link to a framework
  • Add/remove/update a link to a plugin
  • Add/remove/update a link to a tab completion
  • Add/remove/update a link to a theme
  • Add/remove/update a link to a utility
  • Text cleanups/typo fixes

Copyright Assignment

  • This document is covered by the BSD License, and I agree to contribute this PR under the terms of the license. This is for the list submission, not for the project(s) you're adding, I don't care what license the plugins have as long as they have something.

Checklist

  • I have read the CONTRIBUTING document.
  • [x - I apologize, this is my first PR and I'm not quite sure what to do here but I viewed the resulting Markdown after my changes and they all look good] All new and existing tests passed.
  • I have confirmed that the link(s) in my PR is valid.
  • I have signed off my commits. You can use git commit --amend --no-edit --signoff to amend an existing commit, and you can find more details about signing off commits on the DCO GitHub action page here.
  • My entries are single lines and are in the appropriate (plugins, themes, or completions) section, and in alphabetical order in their section.
  • The completion/plugin/theme has a plugin file in the repository that conforms to the ZSH Plugin Standard - TLDR, there's a plugin file with a .plugin.zsh, .zsh or .sh suffix, it is not just bare instructions to be added to .zshrc
  • Any added completions have a readme and a license file in their repository.
  • Any added frameworks have a readme and a license file in their repository.
  • Any added plugins have a readme and a license file in their repository.
  • Any added themes have a screenshot, a readme, and a license file in their repository.
  • Any added utilities have a readme and a license file in their repository.
  • I have stripped any leading and/or trailing zsh-, zsh-plugin and/or oh-my-zsh- substrings from the link's displayed name. This makes it easier to find plugins/themes/completions by name by preventing big clusters in the O and Z sections of the list.

tonywald and others added 2 commits December 15, 2024 11:10
Made some typographical corrections and fixed some Markdown syntax errors.
Copy link
Owner

@unixorn unixorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catches! LGTM

@unixorn unixorn marked this pull request as ready for review December 17, 2024 16:00
@unixorn unixorn merged commit e783a94 into unixorn:main Dec 17, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants