bugfix: not-found or ambiguous constructor treated as var #5303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchellwrosen
commented
Aug 29, 2024
| @@ -465,7 +465,7 @@ result : '{e, Give T} r -> {e} r | |||
| result f = handle !f with cases | |||
| { x } -> x | |||
| { give _ -> resume } -> result resume | |||
| { give A -> resume } -> result resume | |||
| { give T.A -> resume } -> result resume | |||
There was a problem hiding this comment.
This test wasn't quite testing the right thing: since the A constructor is ambiguous in the namespace, it ended up as a variable, essentially testing:
{ give _ -> resume } -> result resume
{ give _ -> resume } -> result resume
rather than the intended
{ give _ -> resume } -> result resume
{ give T.A -> resume } -> result resume
but both produce the same output (complaining that the last pattern is redundant)
aryairani
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #5301
This PR adjusts the parser to properly commit to a branch that fails to resolve a constructor pattern (either due to 0 or 2+ matches in the namespace).
Previously, code like
would erroneously treat
Xas a variable binding ifXdidn't resolve to a single constructor in the namespace.Test coverage
There's a transcript that captures the fix