move /nix to /mnt/nix on Linux workflow #5264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sellout
approved these changes
Aug 2, 2024
| @@ -38,3 +43,5 @@ jobs: | |||
| authToken: '${{ secrets.CACHIX_AUTH_TOKEN }}' | |||
| - name: build all packages and development shells | |||
| run: nix -L build --accept-flake-config --no-link --keep-going '.#all' | |||
| - name: print disk free status | |||
| run: df -h | |||
There was a problem hiding this comment.
I’m guessing this is intentional and not just leftover debugging.
There was a problem hiding this comment.
Yeah I added this intentionally for future debugging
There was a problem hiding this comment.
This seems super weird to me. /mnt is only supposed to be used transiently by a system administrator, not something that should be scripted against. There is no reason (if you care about the FHS) that there should be anything mounted to /mnt to make it a separate filesystem than /. Is /mnt just some other big disk on GHA?
If this works, that's great, I'm just curious, as this seems kinda wrong to me...
Co-authored-by: Greg Pfeil <[email protected]>
aryairani
commented
Aug 2, 2024
.github/workflows/nix-dev-cache.yaml
Outdated
| @@ -24,6 +24,11 @@ jobs: | |||
| - macOS-14 | |||
| steps: | |||
| - uses: actions/checkout@v4 | |||
| - name: set up nix mount points on Linux | |||
There was a problem hiding this comment.
Suggested change
| - name: set up nix mount points on Linux | |
| - name: switch nix mount point on Linux | |
| # On the Linux runner `/` doesn't have enough space, but `/mnt` does. |
aryairani
commented
Aug 2, 2024
Co-authored-by: Greg Pfeil <[email protected]>
ChrisPenner
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
nix is installed in /nix, which on the ubuntu-20.04 runner doesn't have enough space to build everything from scratch, resulting in CI failures on trunk and some PRs, eg #5265
This PR causes the linux runner install nix onto a disk that's bigger than
/fixes #5266
Implementation notes
adds a step to
mount -o bind /mnt/nix /nixbefore installing nix, and this seems to work.Interesting/controversial decisions
Test coverage
the nix steps still pass
Loose ends