Remove support for Git push/pull and gists #5013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisPenner
commented
May 28, 2024
| deriving (Eq) | ||
|
|
||
| -- | Open the codebase at the given location, or create it if one doesn't already exist. | ||
| withOpenOrCreateCodebase :: |
There was a problem hiding this comment.
I was surprised this was now unused, it turns out there's actually a separate withOpenOrCreateCodebase in Unison.Codebase.Init 🤷🏼♂️
Merged
|
I forgot about gists! |
aryairani
approved these changes
May 29, 2024
aryairani
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Git support has long been deprecated in favour of using Unison Share.
This removes all support for pushing and pulling to git repositories as well as the ability to create
gists.This was spurred on by the migration to a project-centric approach without a singular codebase root branch, since continuing to support git with this model would require re-implementing most git sync methods.
Implementation notes
gistcommandInteresting/controversial decisions
I don't think anyone's still actively using the git integration, if we were to ever bring it back we'd probably want to use a Share-style sync rather than Sync22.
Test coverage
I deleted all the tests 😎
Loose ends
Should we also delete the Sync22 machinery?