Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate pushing loose code from UCM #4890

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

ChrisPenner
Copy link
Contributor

Overview

Working with Loose Code (i.e. code outside of a project) on Share is a slower, worse-organized experience than projects.

The plan is to gracefully deprecate Loose Code to help simplify pushing code to Share by only having a single preferred way to do it, and to simplify the implementation of Share as well.

We want to make sure that users still have access to their Share code in the meantime, but know that it's time to move it into projects, so this change will provide a nice message to the user when they try to push loose code to Share:

image

Users can still pull code from loose-code.

Loose code READMEs have been ported to a new 'bio' field on the Share user and Simon will be swapping over the UI to use that ASAP :)

Implementation notes

  • Deletes the implementation of pushing code to Share's loose code, replacing it with a nice deprecation message and instructions on how to move forwards.

Test coverage

Tried it out locally.

Loose ends

After this is deployed and out for a bit I'll remove the implementation from Share as well.

@ChrisPenner ChrisPenner self-assigned this Apr 16, 2024
@aryairani
Copy link
Contributor

Oh, I thought the plan was just to migrate/filter UCM's loose code into a project? I think we are ready for that.

Is the goal of this PR then just to block updates to loose code README since you're in the middle of manually converting those and need to block further writes?

@ChrisPenner
Copy link
Contributor Author

I thought the plan was just to migrate/filter UCM's loose code into a project?

We may choose to do that, but I wouldn't say I necessarily had a plan figured out for it.

I think the biggest thing is that I'd like to start to push people away from loose code towards projects just so whatever we do decide to do is low friction since everyone has already left loose code.

I'd rather not port loose code into projects since those would be really weird projects and likely would cause performance issues in rendering code, computing name lookups, syncing with global defn search, etc.

If we allow users to still pull from loose code they can port it to a proper project at their leisure, if we need to kill loose code for good in the future we can investigate other tacts.

@ChrisPenner ChrisPenner merged commit 8f57a92 into trunk Apr 17, 2024
16 checks passed
@ChrisPenner ChrisPenner deleted the cp/deprecate-loose-code-push branch April 17, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants