fix bug in suffixifyByHash / suffixifyByHashName

unisonweb · Sep 26, 2024 · 1e44418 · 1e44418
1 parent cc4af4b
commit 1e44418
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/unison-core/src/Unison/Name.hs b/unison-core/src/Unison/Name.hs
@@ -575,7 +575,7 @@ suffixifyByHash fqn rel =
 
     isOk :: Name -> Bool
     isOk suffix =
-      Set.size matchingRefs == 1 || matchingRefs == allRefs
+      matchingRefs == allRefs
       where
         matchingRefs :: Set r
         matchingRefs =
@@ -598,7 +598,7 @@ suffixifyByHashName fqn rel =
 
     isOk :: Name -> Bool
     isOk suffix =
-      (Set.size matchingRefs == 1 || matchingRefs == allRefs)
+      matchingRefs == allRefs
         -- Don't use a suffix of 2+ aliases if any of then are non-local names
         && case numLocalNames of
           0 -> True

diff --git a/unison-src/transcripts/fix-5374.output.md b/unison-src/transcripts/fix-5374.output.md
@@ -40,6 +40,7 @@ scratch/main> view thing
   thing : Nat
   thing =
     use Nat +
+    use indirect foo
     foo + foo
 
 scratch/main> edit thing
@@ -56,6 +57,7 @@ scratch/main> edit thing
 thing : Nat
 thing =
   use Nat +
+  use indirect foo
   foo + foo
 ```