Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Fix month calculation between dates #77

Merged
merged 2 commits into from
Apr 17, 2022
Merged

Conversation

rntdrts
Copy link
Contributor

@rntdrts rntdrts commented Apr 17, 2022

Fixes #69

@rntdrts rntdrts requested review from anmar256 and jpmmadeira April 17, 2022 07:06
@codecov
Copy link

codecov bot commented Apr 17, 2022

Codecov Report

Merging #77 (a94c614) into master (ce063dd) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
+ Coverage   89.11%   89.18%   +0.07%     
==========================================
  Files           3        3              
  Lines         634      629       -5     
==========================================
- Hits          565      561       -4     
  Misses         44       44              
+ Partials       25       24       -1     
Impacted Files Coverage Δ
carbon.go 90.21% <100.00%> (-0.25%) ⬇️
translator.go 65.51% <100.00%> (+6.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f18c311...a94c614. Read the comment docs.

@rntdrts rntdrts merged commit 2bcf706 into master Apr 17, 2022
@rntdrts rntdrts deleted the fix-diff-in-dates branch April 17, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Error in DiffInMonths function
2 participants