Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Fix language, use go:embed #76

Merged
merged 3 commits into from
Apr 16, 2022
Merged

[RFC] Fix language, use go:embed #76

merged 3 commits into from
Apr 16, 2022

Conversation

rntdrts
Copy link
Contributor

@rntdrts rntdrts commented Apr 16, 2022

Use go:embed https://pkg.go.dev/embed to not need to declare GOPATH and have language support.

This way we can have access to the languages. However, It requires that we use go version above 1.16.

@rntdrts rntdrts requested review from anmar256 and jpmmadeira April 16, 2022 13:30
@codecov
Copy link

codecov bot commented Apr 16, 2022

Codecov Report

Merging #76 (8c9a2a9) into master (ce063dd) will increase coverage by 0.99%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
+ Coverage   89.11%   90.10%   +0.99%     
==========================================
  Files           3        3              
  Lines         634      637       +3     
==========================================
+ Hits          565      574       +9     
+ Misses         44       39       -5     
+ Partials       25       24       -1     
Impacted Files Coverage Δ
carbon.go 91.18% <100.00%> (+0.71%) ⬆️
translator.go 65.51% <100.00%> (+6.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a000e35...8c9a2a9. Read the comment docs.

@rntdrts rntdrts merged commit f18c311 into master Apr 16, 2022
@rntdrts rntdrts deleted the fix-language-import branch April 16, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants