[RFC][UN-13487] Fix diff in months #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asantos00
force-pushed
the
UN-13487/fix-diff-in-months
branch
from
88ae08c to
dc615c0
Compare
asantos00
commented
Jun 20, 2018
carbon.go
Outdated
| @@ -1187,7 +1187,7 @@ func (c *Carbon) DiffInMonths(carb *Carbon, abs bool) int64 { | |||
| if (diffHr - hrLastMonth) >= 0 { | |||
| var m int64 | |||
| if c.Year() < carb.Year() { | |||
| m = (int64(monthsPerYear) - int64(c.In(time.UTC).Month())) + (int64(carb.In(time.UTC).Month()) - 1) | |||
| m = int64(monthsPerYear) - int64(c.In(time.UTC).Month()) + int64(carb.In(time.UTC).Month()) - 1 | |||
There was a problem hiding this comment.
Go was giving a error reporting redundant parameters
Codecov Report
@@ Coverage Diff @@
## master #43 +/- ##
==========================================
- Coverage 91.49% 91.48% -0.01%
==========================================
Files 3 3
Lines 858 857 -1
==========================================
- Hits 785 784 -1
Misses 48 48
Partials 25 25
Continue to review full report at Codecov.
|
hfcorreia
approved these changes
Jun 20, 2018
asantos00
force-pushed
the
UN-13487/fix-diff-in-months
branch
from
5fc365d to
7761d0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://uniplaces.atlassian.net/browse/UN-13487
What this does?
13and when summed with years' difference would count a year twicediffInMonthsfrom php carbon` tests check here