Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #52 +/- ##
=======================================
Coverage 98.07% 98.07%
=======================================
Files 23 23
Lines 104 104
Branches 5 5
=======================================
Hits 102 102
Misses 2 2
Continue to review full report at Codecov.
|
|
No credit due to me, I just did a google search and shared something I found that was neat :) |
|
You should probably include the bugfixed version from lower down in the thread though, I hadn't seen it yet. microsoft/TypeScript#25987 (comment) type KnownKeys<T> = {
[K in keyof T]: string extends K ? never : number extends K ? never : K
} extends {[_ in keyof T]: infer U} ? ({} extends U ? never : U) : never; |
Owner
Author
|
@Gerrit0 thanks! Updated and added tests. :) |
Owner
Author
|
🎉 This PR is included in version 1.32.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally by @ajafff and learn from @Gerrit0
Is it ok to you about sharing
KnownKeys<T>in this library?I mentioned your names in https://github.com/unional/type-plus/compare/known-keys?expand=1#diff-3fd41558ce97781e45aa28e9885e9c2e
Reference:
microsoft/TypeScript#25987 (comment)
Best,
Uni