Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#55: swapped is-plain-obj for is-plain-object #134

Closed
wants to merge 1 commit into from

Conversation

mummybot
Copy link

Closes GH-55.

I have read the comment thread and seen the open PR regarding the docs for transpiling individual node_modules. We have it working on our specific project with this technique.

However we have created our own internal library which is shared in a large organisation across multiple teams, all of whom need to support IE11. Because our internal library includes remark, unified and thus is-plain-obj, every team will have to make this change in their build tooling to transpile node_modules/is-plain-obj.

We would very much appreciate it if you were to swap out the libraries, as it is the simplest of changes and makes unified work in IE11 straight out of the box.

@mummybot mummybot changed the title 55: swapped is-plain-obj for is-plain-object #55: swapped is-plain-obj for is-plain-object Apr 28, 2021
@ChristianMurphy
Copy link
Member

However we have created our own internal library which is shared in a large organisation across multiple teams, all of whom need to support IE11. Because our internal library includes remark, unified and thus is-plain-obj, every team will have to make this change in their build tooling to transpile node_modules/is-plain-obj.

A build tool is already needed to use unified in the browser, regardless of this dependency. 😕

We would very much appreciate it if you were to swap out the libraries, as it is the simplest of changes and makes unified work in IE11 straight out of the box.

I don't think it make sense to add an IE11 polyfill for everyone, when build tooling which is already needed does it automatically, and only where needed.


at a more overarching level, the unified community is moving towards ES6 features, like ES Modules #121 and let/const/class unifiedjs/rfcs#4.
Which are supported in node and in ever green browsers https://kangax.github.io/compat-table/es6

I appreciate that fact that supporting IE11 can be a challenge, it's something I've faced myself.
But Open Source continuing to support a browser which has been long since abandoned isn't sustainable.

Tools like the ones in unifiedjs/unifiedjs.github.io#9 offer a way forward, assistance improving the documentation is welcome, and if you want to create a shareable build configuration for IE11 support that would be welcome as well.

@ChristianMurphy ChristianMurphy added the 🙅 no/wontfix This is not (enough of) an issue for this project label Apr 28, 2021
@mummybot
Copy link
Author

I'll try again :)
#135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙅 no/wontfix This is not (enough of) an issue for this project
Development

Successfully merging this pull request may close these issues.

Browser support
2 participants