Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix export #15

Merged
merged 3 commits into from
Dec 23, 2021
Merged

Fix export #15

merged 3 commits into from
Dec 23, 2021

Conversation

remcohaszing
Copy link
Member

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

configureUnifiedLanguageServer was exported, createUnifiedLanguageServer is supposed to be exported instead.

`configureUnifiedLanguageServer` was exported,
`createUnifiedLanguageServer` is supposed to be exported instead.
@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Dec 23, 2021
@wooorm
Copy link
Member

wooorm commented Dec 23, 2021

Maybe add a test for it, too?

import {configureUnifiedLanguageServer} from '../lib/index.js'

@remcohaszing
Copy link
Member Author

I’m not sure what such a test looks like. This is more configuration than code really.

@wooorm
Copy link
Member

wooorm commented Dec 23, 2021

Something like https://github.com/remarkjs/remark-rehype/blob/3a9bd089953dc12b82b8403d2bc731ea957c5895/test.js#L8-L14.

And this is using an export map, so you can use the package name to get the public api? import whateverYouWant from 'unified-language-server'?

@codecov-commenter

This comment has been minimized.

package.json Outdated Show resolved Hide resolved
@wooorm wooorm changed the title Fix export from lib Fix export Dec 23, 2021
@wooorm wooorm merged commit 6e10e72 into unifiedjs:main Dec 23, 2021
@wooorm wooorm added the 💪 phase/solved Post is done label Dec 23, 2021
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Dec 23, 2021
@wooorm
Copy link
Member

wooorm commented Dec 23, 2021

released!

@remcohaszing remcohaszing deleted the fix-exports branch March 13, 2022 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 phase/solved Post is done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants