Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Included nested tables in document.Tables() output #257

Merged
merged 4 commits into from
Apr 3, 2019
Merged

Included nested tables in document.Tables() output #257

merged 4 commits into from
Apr 3, 2019

Conversation

freb
Copy link
Contributor

@freb freb commented Mar 29, 2019

See #256.

@gunnsth gunnsth requested a review from nkryuchkov March 29, 2019 20:37
@gunnsth
Copy link
Contributor

gunnsth commented Mar 30, 2019

@freb Can you include a test case? Would be good if it is limited to only this part, not necessarily an entire file, unless its small.

nkryuchkov
nkryuchkov suggested changes Mar 31, 2019
View reviewed changes
document/document.go Show resolved Hide resolved
document/document_test.go Outdated Show resolved Hide resolved
@gunnsth gunnsth merged commit 32d0f79 into unidoc:master Apr 3, 2019
@gunnsth gunnsth mentioned this pull request Apr 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkryuchkov nkryuchkov nkryuchkov requested changes

@gunnsth gunnsth gunnsth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@freb @gunnsth @nkryuchkov