Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fmt::Display wrapper to pad/truncate using correct width #47

Closed
wants to merge 1 commit into from
Closed

Add fmt::Display wrapper to pad/truncate using correct width #47

wants to merge 1 commit into from

Conversation

Jules-Bertholet
Copy link
Contributor

Fixes #9

Manishearth
Manishearth requested changes May 10, 2024
View reviewed changes
Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like a large amount of code for something minor, and plus it involves expanding a trait (which is breaking). I'd rather not have this

@Jules-Bertholet
Copy link
Contributor Author

Fair

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A helper function to calculate the width should be used in fmt funcs
2 participants
@Jules-Bertholet @Manishearth