allkeys.txt ignorables are not variable #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
markusicu
requested review from
srl295,
echeran,
macchiati,
cjchapman and
pedberg-icu
|
Hi @macchiati thanks for approving the output unicode-org/cldr#3983 which I just merged. Please remember to review the generator changes here. Anyone else is welcome as well! |
macchiati
approved these changes
Aug 27, 2024
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Primary weights above the special one for U+FFFE and up to variableTop are variable. Ignorable CEs with primary=0 are not variable.
Remove the "variable if last CE was" logic, and don't tell a function on class UCA where its own variableTop is.
Output: