Skip to content

Conversation

@eggrobin
Copy link
Member

@eggrobin eggrobin commented May 30, 2024

… and fix it.

UTC-180-C19 Consensus: Assign the Other_Grapheme_Extend property to U+0CC0, U+0CC7, U+0CC8, and U+0CCA, U+0CCB (Kannada vowel signs II, EE, AI, O, and OO), as well as U+1B3B, U+1B3D, and U+1B43 (Balinese vowel signs ra repa tedung, la lenga tedung, and pepet tedung), thereby changing their Grapheme_Cluster_Break property from SpacingMark to Extend, ensuring consistency of legacy grapheme clusters with canonical equivalence. For Unicode 16.0. See L2/24-162 item 6.2, PRI-494#ID20240422114157, and PRI-494#ID20240422120150.

See https://github.com/unicode-org/properties/issues/287.

Previously: #645.

macchiati
macchiati previously approved these changes May 30, 2024
Copy link
Member

@macchiati macchiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Might want to wait for props meeting, in case anyone has qualms.

@eggrobin
Copy link
Member Author

Might want to wait for props meeting, in case anyone has qualms.

Might want to wait for UTC, since it is a change to the property assignments of existing characters!

@macchiati
Copy link
Member

dooooh ... even better

@markusicu
Copy link
Member

Test still fails:

[INFO] Running org.unicode.text.UCD.TestTestUnicodeInvariants
Error: Got unexpected property values: 1
0CCB          ; Extend≠SpacingMark #      (ೋ)  KANNADA VOWEL SIGN OO

@eggrobin
Copy link
Member Author

Test still fails

I know, I commented on that on the PAG issue. Will fix it here.

Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@eggrobin eggrobin marked this pull request as ready for review July 24, 2024 21:14
@eggrobin eggrobin requested review from macchiati and markusicu July 24, 2024 21:25
@eggrobin eggrobin merged commit ef8d616 into unicode-org:main Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants