Skip to content

Conversation

@roozbehp
Copy link
Contributor

[177-C42] Consensus: Add a new property value Reordering_Killer to IndicSyllabicCategory.txt for Unicode version 16.0. (Ref. L2/23-205 and Section 18 of L2/23-238)

[177-C43] Consensus: Change the InSC property values for the Batak viramas U+1BF2 BATAK PANGOLAT and U+1BF3 BATAK PANONGONAN from Pure_Killer to Reordering_Killer for Unicode version 16.0. (Ref. L2/23-205 and Section 18 of L2/23-238)

[177-A96] Action Item for Roozbeh Pournader, SAH: Add a new property value Reordering_Killer to the Indic Syllabic Category (InSC) property; and change the InSC property values for U+1BF2 BATAK PANGOLAT and U+1BF3 BATAK PANONGONAN from Pure_Killer to Reordering_Killer.

[177-A97] Action Item for Roozbeh Pournader, SAH: Consider the suggestions provided at the end of L2/23-205 for potential updates to the descriptions of the existing InSC property values (Ref. L2/23-205 and Section 18 of L2/23-238)

[177-A98] Action Item for Markus Scherer, PAG: Add Reordering_Killer to the property value aliases for InSC in PropertyValueAliases.txt, for Unicode version 16.0.

Ken-Whistler
Ken-Whistler previously approved these changes Nov 13, 2023
Copy link
Contributor

@Ken-Whistler Ken-Whistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to InSC.txt and PropertyValueAliases.txt look as expected. I am assuming the other file changes are what are necessary to make that happen.

@roozbehp
Copy link
Contributor Author

Looks like some invariant is failing, but I don't know how to locate it from the logs. @eggrobin @markusicu can you please help?

@markusicu
Copy link
Member

Looks like some invariant is failing, but I don't know how to locate it from the logs.

Please try to run the invariant tests locally and see what the output file says:
https://github.com/unicode-org/unicodetools/blob/main/docs/build.md#invariant-checking

Parts of that are a bit outdated; “Run>Run As... Java Application” refers to how we used to run things in Eclipse which may or may not work any more. See earlier sections of that page about how to run things via Maven. (I am currently using IntelliJ for these tools.)

If you get stuck, then one of the team members can pull your PR and see what's going on.

@roozbehp roozbehp requested a review from markusicu November 13, 2023 21:51
@roozbehp
Copy link
Contributor Author

If you get stuck, then one of the team members can pull your PR and see what's going on.

Thanks. I ended up feeling my way in the dark and found the offending invariant test. PTAL.

Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks -- please use squash and merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants