Require at least one keyword for complex messages #841
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #787
Fixes #837
We currently allow complex messages to start with
{{
, sohello
and{{hello}}
mean the exact same thing. As identified in #787, when we add bidi isolation to the syntax (#811), this will mean that each of the following will be valid sequences starting a complex message:.
{{
LRI{{
or{LRI{
RLI{{
or{RLI{
FSI{{
or{FSI{
where LRI, RLI, and FSI represent the U+2066..U+2068 characters.
This seems like a lot, esp. when the only reason why a complex message must be valid even if it has no keywords is to allow for messages like
{{.zip}}
, i.e. ones starting with a literal.
.If we were to instead allow for
\.
as an escape, we could require complex messages to start with a keyword, and then the set of valid sequences starting a complex message reduces to only:.