Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include data in icu_testdata crate #527

Merged
merged 1 commit into from
Mar 4, 2021
Merged

Include data in icu_testdata crate #527

merged 1 commit into from
Mar 4, 2021

Conversation

sffc
Copy link
Member

@sffc sffc commented Mar 4, 2021

Maybe closes #522

CC @klaider: Does this fix the problem you were having?

@sffc sffc requested a review from Manishearth March 4, 2021 15:57
@ghost
Copy link

ghost commented Mar 4, 2021

Thanks! Unfortunately I'm failling to use this as dependency.

Cargo.toml:

[dependencies]
icu_testdata = { git = "https://github.com/unicode-org/icu4x/tree/master/resources/testdata" }

It fails to download the crate.

UPDATE: I meant to use this commit, not master, but it already fails to do so.

@sffc
Copy link
Member Author

sffc commented Mar 4, 2021

Cargo.toml:

[dependencies]
icu_testdata = { git = "https://github.com/unicode-org/icu4x/tree/master/resources/testdata" }

That doesn't look like a valid Cargo.toml git dependency.

https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html

Try

icu_testdata = { git = "https://github.com/unicode-org/icu4x", branch = "sffc-patch-1" }

According to rust-lang/cargo#1462, Cargo should find this package even though it's in a subdirectory.

@ghost
Copy link

ghost commented Mar 4, 2021

Now it works. Looks like the icu_datetime crate changed the MockDateTime item location to a mock module.

Manishearth
Manishearth previously approved these changes Mar 4, 2021
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@coveralls
Copy link

Pull Request Test Coverage Report for Build 714c608eacdc5c411f488862131c3bfe2c347e1c-PR-527

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.707%

Totals Coverage Status
Change from base Build 40c5dd3205c8fa4beee91a9ac47b18f628a7e550: 0.0%
Covered Lines: 4851
Relevant Lines: 6672

💛 - Coveralls

@sffc sffc merged commit 2d62207 into master Mar 4, 2021
@sffc sffc deleted the sffc-patch-1 branch March 4, 2021 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to depend on icu_testdata?
3 participants