-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enumerated property completeness tests #4645
Merged
sffc
merged 14 commits into
unicode-org:main
from
kartva:enumerated-property-completeness-tests
Mar 10, 2024
Merged
Enumerated property completeness tests #4645
sffc
merged 14 commits into
unicode-org:main
from
kartva:enumerated-property-completeness-tests
Mar 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashu26jha
reviewed
Mar 4, 2024
ashu26jha
reviewed
Mar 4, 2024
sffc
requested changes
Mar 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Example failing test output:
|
sffc
previously approved these changes
Mar 5, 2024
sffc
previously approved these changes
Mar 6, 2024
sffc
approved these changes
Mar 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4283
Description of changes:
create_const_array
macro that produces an array of tuples of the values and names of the constants defined in an impl block.Example output on modifying
Wide = EastAsianWidth(2); //name="W"
toEastAsianWidth(52)
: