Adding Japanese date/datetime example #1886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
previously approved these changes
May 16, 2022
Manishearth
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following advice from #1844 (comment) , I tried permutations of importing
icu_providerwithserde,icu_testdatawithserde, and other troubleshooting. However, I found importingicu_calendaras adev-dependenciesfixed the error, and was the only way I found to be fix it. Part of me wonders if this is related to running the code within the comments/docs section. Either way, I do not like this self-referencing dependency, and am continuing to troubleshoot the error.To reproduce the error, delete
icu_calendar = { version = "0.6", path = "../calendar", features = ["serde"] }fromcomponents/calendar/Cargo.toml, and runcargo test -p icu_calendar --doc japanese