Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-20558 Fix compat issue with DateTimePatternGenerator fallback to default root locale #632

Merged

Commits on Apr 24, 2019

  1. ICU-20558 Fix regression in DateTimePatternGenerator

    This fixes a regression introduced by commit 
    b12a927 for issue ICU-13778.
    
    The above commit improved the error checking in the
    DateTimePatternGenerator class, adding checks for errors/failures
    where there previously was none at all. This was done in order to
    catch catastrophic errors like out-of-memory (OOM), and properly
    report them to the caller, rather than ignoring/hiding these errors.
    
    However, in doing so it exposed a case where the code was depending
    on ignoring errors in order to fall-back to the Gregorian calendar
    when the default ICU locale is set to root.
    
    This restores the previous behavior, by allowing the error of
    U_MISSING_RESOURCE_ERROR to fall-though and continue without
    reporting back an error to the caller.
    
    Note: This regression was technically introduced in ICU 63, and
    also effects ICU 64 as well.
    jefgen committed Apr 24, 2019
    Configuration menu
    Copy the full SHA
    3da02ca View commit details
    Browse the repository at this point in the history