Skip to content

Commit

Permalink
Add MessageFormat2 support with ICU4J executor (#175)
Browse files Browse the repository at this point in the history
* Split testdata_gen.py into multiple modules

* Add draft test schema

* Add MF2 schemas

* Add preliminary code for ICU4J executor for MF2 tests

* Add MF2 test generator

* Fix unit test by setting time zone explicitly

* Revert "Fix unit test by setting time zone explicitly"

This reverts commit b524cbc.

* Use Date constructor that uses local time zone, which matches implicit formatting behavior

* Pin the default time zone and locale to make ICU formatting tests more resilient

* Re-add ability to read from JSON in testdata-gen

* Add MF2 testgen logic to new file

* Extract TestType into separate file

* Re-add MF2 test generator to testdata_gen

* Add syntax tests

* Add format_to_parts testType to MF2 schemas

* Add missing description for placeholder test

* Remove invalid comma

* Reorganise syntax tests

* Add integer formatter tests

* Move MF2 ICU4J executor code to directory for ICU4J v74 code

* Import MF2 tests from message-format-wg repo

* Move TestType to new file

* Add separate README for testgen

* Update MF2 test schema

* Revert test_schema changes

* Update testgen_schema

* Update MF2 testgen and schemas

* Rename pattern property to src

* Enable test resources from `testgen` directory

* Update executor to recognize new schema for test input cases for MF2

* Update testgen for new schema and arrangement of message_fmt2 source test data

* Enable schema validation on generated test cases for message_fmt2

* Fix configuration for message_fmt2 executor

* Add (currently ignored) test that can reproduce parsing error on number literal operand

---------

Co-authored-by: Elango Cheran <[email protected]>
  • Loading branch information
mradbourne and echeran authored Jun 24, 2024
1 parent 4b31320 commit 5b7d66d
Show file tree
Hide file tree
Showing 37 changed files with 4,228 additions and 26 deletions.
5 changes: 5 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

.pylintrc
.idea
.devcontainer

executors/rust/target/
executors/cpp/executor
Expand Down Expand Up @@ -37,7 +38,11 @@ testdriver/.local-chrome/
testgen/*.json

TEMP_DATA/*
TEMP_DATA_100/*

# log files (including logrotate state and file backups)
debug.log*
logrotate.state

# Maven
dependency-reduced-pom.xml
Loading

0 comments on commit 5b7d66d

Please sign in to comment.