CLDR-9774 Enable test for missing/extra English names for BCP47 keys/types #4364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedberg-icu
commented
Feb 12, 2025
| @@ -78,9 +78,6 @@ public static void main(String[] args) { | |||
| } | |||
|
|
|||
| public void TestEnglishKeyTranslations() { | |||
| logKnownIssue( | |||
| "cldr7631", | |||
| "Using just warnings for now, until issues are resolved. Change WARNING/ERROR when removing this."); | |||
There was a problem hiding this comment.
CLDR-7631 was resolved a while ago
There was a problem hiding this comment.
I don't know why my sweep didn't find this. Is this function actually called?
There was a problem hiding this comment.
@srl295 Maybe because until a day or so ago the tests in this file were not being run (since they were not included in TestAl())?
pedberg-icu
force-pushed
the
CLDR-9774-test-en-names-for-bcp47-keys-values
branch
from
9516e07 to
22decaf
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
macchiati
approved these changes
Feb 12, 2025
srl295
approved these changes
Feb 12, 2025
| @@ -78,9 +78,6 @@ public static void main(String[] args) { | |||
| } | |||
|
|
|||
| public void TestEnglishKeyTranslations() { | |||
| logKnownIssue( | |||
| "cldr7631", | |||
| "Using just warnings for now, until issues are resolved. Change WARNING/ERROR when removing this."); | |||
There was a problem hiding this comment.
I don't know why my sweep didn't find this. Is this function actually called?
pedberg-icu
deleted the
CLDR-9774-test-en-names-for-bcp47-keys-values
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-9774
Start using the test to check for missing or extra English display names for relevant BCP47 keys and types. Most of this was already in unittest/TestBCP47.java, but the tests there were not being run until I added them to TestAll() in PR #4358. Then for this PR I just had to switch to using normal error logging, and add some test skips (one marked with a logKnownIssue).
Tested this by temporarily adding some new entries in common/bcp47 files without translations in English and verifying that the test caught them.
ALLOW_MANY_COMMITS=true