CLDR-18294 Avoid null Bailey values for paths with INHERITANCE_MARKER #4363
+20
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Remove some paths with INHERITANCE_MARKER in XML for eight locales -Restore code-fallback in XMLSource.java, maybe temporarily, for some paths -Code comments reference this ticket for follow up in v48
|
@macchiati this is what I could do before leaving the office today. I didn't do anything with the personNames paths, or with those marked "Ok to remove path; inherited" in the spreadsheet. |
macchiati
approved these changes
Feb 12, 2025
|
Looks good. Can you also add the test (can be separate PR) with an exception set for any remaining issues (and a logKnownIssue if that set is !isEmpty()? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Remove some paths with INHERITANCE_MARKER in XML for eight locales
-Restore code-fallback in XMLSource.java, maybe temporarily, for some paths
-Code comments reference this ticket for follow up in v48
CLDR-18294
ALLOW_MANY_COMMITS=true