CLDR-18050 spec: use small caps for h5 #4225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srl295
requested review from
macchiati,
AEApple,
btangmu,
pedberg-icu and
DraganBesevic
macchiati
requested changes
Dec 4, 2024
| @@ -29,3 +29,7 @@ | |||
| .markdown-alert-important .markdown-alert-title { | |||
| color: blueviolet; | |||
| } | |||
|
|
|||
| .body h5 { | |||
| font-variant: small-caps; | |||
There was a problem hiding this comment.
Needs to be the following, otherwise the size is too small (and we want to guarantee it is bold)
Suggested change
| font-variant: small-caps; | |
| font-variant: small-caps; | |
| font-size: medium; | |
| font-weight: bold; |
- per review comment Co-authored-by: macchiati <[email protected]>
macchiati
approved these changes
Dec 4, 2024
pedberg-icu
pushed a commit
to pedberg-icu/cldr
that referenced
this pull request
Dec 8, 2024
(cherry picked from commit 9c044e1)
pedberg-icu
pushed a commit
that referenced
this pull request
Dec 8, 2024
(cherry picked from commit 9c044e1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-18050
ALLOW_MANY_COMMITS=true
Review Notes