CLDR-17947 site: css: fix breakage #4067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge conflict broke css for img compare https://cldr.unicode.org/index/keyboard-workgroup to
srl295
requested review from
conradarcturus,
mcdurdin,
macchiati,
AEApple and
btangmu
|
✨ deployed to https://c6075b6b.cldr.pages.dev |
mcdurdin
approved these changes
Sep 20, 2024
macchiati
approved these changes
Sep 20, 2024
|
If the image width was the problem, it now appears solved:
https://cldr.unicode.org/index/language-support-levels#language-selection-ui
…On Fri, Sep 20, 2024 at 12:58 PM Steven R. Loomis ***@***.***> wrote:
Merged #4067 <#4067> into main.
—
Reply to this email directly, view it on GitHub
<#4067 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEMCOYBGVJIBMVQWCAITZXR46FAVCNFSM6AAAAABORAF3NGVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGM2DKMZQGQ2DSMQ>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
Note that the h1, h2, ... styles are still incorrect.
Eg, https://cldr.unicode.org/downloads/cldr-46#current-levels
This is an h4 element, but italic. All of them down to h5 should be bold
and non-italic. It appears that our h4 is not overriding the font-style
correctly; all of *our* site styles should have
font-weight: bold;
font-style: normal;
except for h6, which will have
font-weight: bold;
font-style: italic;
…On Fri, Sep 20, 2024 at 3:08 PM Mark Davis Ⓤ ***@***.***> wrote:
If the image width was the problem, it now appears solved:
https://cldr.unicode.org/index/language-support-levels#language-selection-ui
On Fri, Sep 20, 2024 at 12:58 PM Steven R. Loomis <
***@***.***> wrote:
> Merged #4067 <#4067> into main.
>
> —
> Reply to this email directly, view it on GitHub
> <#4067 (comment)>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ACJLEMCOYBGVJIBMVQWCAITZXR46FAVCNFSM6AAAAABORAF3NGVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGM2DKMZQGQ2DSMQ>
> .
> You are receiving this because your review was requested.Message ID:
> ***@***.***>
>
|
this is just the PR for the broken curly brace. I wasn't aware something was incorrect. - can we keep issues on the issue? |
|
Moved my comment to https://unicode-org.atlassian.net/browse/CLDR-17947?focusedCommentId=177549 |
conradarcturus
pushed a commit
that referenced
this pull request
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge conflict broke css for img
compare the images https://cldr.unicode.org/index/keyboard-workgroup to https://c6075b6b.cldr.pages.dev/index/keyboard-workgroup
CLDR-17947
ALLOW_MANY_COMMITS=true