-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDR-5854 Add-examples-for-relative-dates-and-times #4060
CLDR-5854 Add-examples-for-relative-dates-and-times #4060
Conversation
9b46296
to
09276e0
Compare
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
@macchiati @srl295 @btangmu Hello! I've made a new PR for this ticket since the old one was (accidentally) trying to merge to the wrong branch. The main thing I wanted to address is that the casing/context side isn't covered by this implementation for two main reasons (the examples for Romanian in the markdown table show this):
In terms of just getting examples in for the relative items, however, it may still be useful. |
@@ -326,6 +326,19 @@ public void setCachingEnabled(boolean enabled) { | |||
} | |||
}; | |||
|
|||
// map relativeTimePattern counts to numeric examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might need to make this map dependent on locale. That can be done under CLDR-18025 "Further work on examples for relative dates and times".
String skeleton; | ||
String type = parts.findAttributeValue("field", "type"); | ||
if (type.startsWith("hour")) { | ||
skeleton = "Hm"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to make this "jm" or "Cm" to use hour cycle prefs based on locale. That can be done under CLDR-18025 "Further work on examples for relative dates and times".
CLDR-5854
ALLOW_MANY_COMMITS=true