Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-15817 Update Example Generator (#3978) #4046

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Sep 12, 2024

CLDR-15817

  • This PR completes the ticket.

This has been reviewed in #3978 but was merged to the wrong branch.

Just need a rubber stamp review of the second merge commit to get @haytenf ’s work merged in.

ALLOW_MANY_COMMITS=true

@srl295
Copy link
Member Author

srl295 commented Sep 12, 2024

okay— bit of a divergence happened on main, so please check the second commit.

Copy link
Contributor

@haytenf haytenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you @srl295 for resolving the merge conflicts.

@srl295 srl295 merged commit 91e1079 into main Sep 13, 2024
16 checks passed
@srl295 srl295 deleted the CLDR-15817-Update-ExampleGenerator branch September 13, 2024 16:02
haytenf added a commit to haytenf/cldr that referenced this pull request Sep 17, 2024
conradarcturus pushed a commit that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants